Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Fix byte index out of range panic for likely error responses.#713

Merged
shawnbuso merged 1 commit into
googlecodelabs:mainfrom
shawnbuso:imglen
Mar 9, 2022
Merged

Fix byte index out of range panic for likely error responses.#713
shawnbuso merged 1 commit into
googlecodelabs:mainfrom
shawnbuso:imglen

Conversation

@shawnbuso
Copy link
Copy Markdown
Collaborator

No description provided.

@shawnbuso shawnbuso requested a review from DragonRider0o0 March 9, 2022 18:18
@shawnbuso shawnbuso force-pushed the imglen branch 2 times, most recently from 07a435b to c9c6bd9 Compare March 9, 2022 19:12
@shawnbuso shawnbuso changed the title Fix byte index out of range error for absurdly small images. Fix byte index out of range panic for likely error responses. Mar 9, 2022
Copy link
Copy Markdown
Contributor

@DragonRider0o0 DragonRider0o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider printing the bytes, they might contain a brief error message.

@shawnbuso shawnbuso merged commit 85498c4 into googlecodelabs:main Mar 9, 2022
@shawnbuso shawnbuso deleted the imglen branch March 9, 2022 22:36
Comment thread claat/go.mod
@@ -4,6 +4,7 @@ go 1.16

require (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tấc cả ngôn ngữ

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants