This repository was archived by the owner on Mar 20, 2026. It is now read-only.
chore: declare version as separate variable#450
Merged
Conversation
This is the way release-please currently expects the version to be declared. https://github.com/googleapis/release-please/blob/4e0bf11b7f4217b5c6b8cd1aa9ea4db1bce06b89/src/updaters/python/setup-py.ts#L36
googlebot
added
the
cla: yes
odeke-em
approved these changes
May 13, 2020
Contributor
odeke-em
left a comment
odeke-em
left a comment
There was a problem hiding this comment.
Nice, thank you @busunkim96, LGTM!
skuruppu
pushed a commit
to renovate-bot/python-spanner-django
that referenced
this pull request
May 14, 2020
This is the way release-please currently expects the version to be declared. https://github.com/googleapis/release-please/blob/4e0bf11b7f4217b5c6b8cd1aa9ea4db1bce06b89/src/updaters/python/setup-py.ts#L36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the way release-please currently expects the version to be declared. https://github.com/googleapis/release-please/blob/4e0bf11b7f4217b5c6b8cd1aa9ea4db1bce06b89/src/updaters/python/setup-py.ts#L36
For #449