impl(rust): feature gate rpc samples

[dbolduc]

We have a generate-rpc-samples codec option, but it doesn't factor into any of the templates. We want it to control this block of code.

We will want to turn it off in veneer-like things like the internal, generated pubsub dataplane.

[gemini-code-assist]

Summary of Changes

Hello @dbolduc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a feature gate for RPC sample generation within Rust templates. By introducing the ModelCodec.GenerateRpcSamples option, it allows for conditional rendering of client method examples, enabling the disabling of these samples in specific contexts, such as internal, generated data planes. This provides greater control over the generated code and reduces unnecessary boilerplate where samples are not desired.

Highlights

• Feature Gating RPC Samples: Introduced a new feature gate, ModelCodec.GenerateRpcSamples, to control the inclusion of RPC samples in generated Rust code.
• Conditional Template Rendering: The block of code responsible for generating client method examples in the client_method_sample.mustache template is now conditionally rendered based on the ModelCodec.GenerateRpcSamples flag.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a feature gate for generating RPC samples in Rust, controlled by the generate-rpc-samples codec option. The implementation wraps the relevant Mustache template block with a conditional. My review focuses on improving the consistency of accessing the new feature flag within the template, suggesting a more explicit path that aligns with existing patterns in the file. This should enhance code clarity and maintainability.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.10%. Comparing base (228fad1) to head (b635b83).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3426   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files         161      161           
  Lines       13420    13420           
=======================================
  Hits        11019    11019           
  Misses       1844     1844           
  Partials      557      557           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.