refactor(internal/semver): move legacysemver and update imports#3098
Merged
julieqiu merged 2 commits intogoogleapis:mainfrom Dec 1, 2025
Merged
refactor(internal/semver): move legacysemver and update imports#3098julieqiu merged 2 commits intogoogleapis:mainfrom
julieqiu merged 2 commits intogoogleapis:mainfrom
Conversation
noahdietz
previously approved these changes
Dec 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 152 152
Lines 12184 12184
=======================================
Hits 9831 9831
Misses 1893 1893
Partials 460 460 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
noahdietz
approved these changes
Dec 1, 2025
Move the `internal/legacylibrarian/legacysemver` package to `internal/semver`, since we plan to continue using this logic for version bumping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
internal/legacylibrarian/legacysemverpackage tointernal/semver, since we plan to continue using this logic for version bumping.