Key value store firestore - Byte store to use with Parent Document Retriever#103
Open
Freezaa9 wants to merge 7 commits intogoogleapis:mainfrom
Open
Key value store firestore - Byte store to use with Parent Document Retriever#103Freezaa9 wants to merge 7 commits intogoogleapis:mainfrom
Freezaa9 wants to merge 7 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
the
api: firestore
Collaborator
|
Thank you @Freezaa9 , we will review shortly. |
Author
|
Hello, any news ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing Firestore as a key-value store, (ByteStore)
I used Redis store as example:
https://python.langchain.com/api_reference/_modules/langchain_community/storage/redis.html#RedisStore
Test include:
I didn't use the function from document_converter.py and document_loader.py used in Firestorevectorstore because it made the code overcomplicate for this implementation.
Fixes #102 🦕