Add methods for Models API#7562
Merged
tswast merged 12 commits intogoogleapis:masterfrom Apr 4, 2019
Merged
Conversation
* Generate protos for Models API. The Models API is a component of the bigquery_v2 interface. It is not available as a gRPC API, but it does provide protocol buffers. This commit adds those protocol buffers to the client so that they can be used to avoid much manual work to create resource classes that can be serialized to/from JSON.
* Fixes BQ Models API generated code for Python 2.7 * Format quoted strings as plain text.
* Add handwritten model API classes. These classes provide the top-level classes for the Model API. The protocol buffer objects are used for all sub-objects. The pattern for mutable properties follows the same as with Table and Dataset: a `_properties` dictionary contains the property values in the REST API format. * Address review comments in Model. Use setdefault for labels. Simplify setter logic for expires. * Combine error messages for too many and too few parts in model/table ID.
* Regen BigQuery Model API classes.
This commit is auto-generated by:
SYNTHTOOL_GOOGLEAPIS=$HOME/src/googleapis-private python -m synthtool
* Update test for Model to new representation of TrainingRun.startTime.
* Add client methods for Models API. * Adds hack to workaround milliseconds format for model.trainingRun.startTime. * Adds code samples for Models API, which double as system tests.
Even if the Models API itself is considered GA, I'd like to mark the client methods as Beta for a time to give us some more ability to make breaking changes until we're sure of the public interface we want to expose.
Contributor
Author
|
Shouldn't be too much to review, as all these commits were reviewed in the private version. Looks like there are a few conflicts now, though. I'll see what I can do about those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Models API adds the following methods to the BigQuery client:
get_modelupdate_modeldelete_modellist_modelsfor managing models created by BigQuery ML queries. Also added are models resources, which provide additional statistics about the models resource such as details about the training run.