Skip to content

Docstring parse errors and switch from 'string' to 'str'#1774

Merged
daspecster merged 3 commits intogoogleapis:masterfrom
daspecster:fix-docstring-parse-errors
May 5, 2016
Merged

Docstring parse errors and switch from 'string' to 'str'#1774
daspecster merged 3 commits intogoogleapis:masterfrom
daspecster:fix-docstring-parse-errors

Conversation

@daspecster
Copy link
Copy Markdown
Contributor

  • There were just a couple typos with a semi-colon instead of a colon.
  • Also, in the files that I had touched I converted types from string to str which is better supported by the documentation parsers.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2016
query = query.select_projects('project-1')
query = query.select_projects('project-1', 'project-2')

:type args: str

This comment was marked as spam.

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented May 5, 2016

Nice finds. I'm surprised sphinx-docs doesn't complain about some of those ; for : typos

@daspecster
Copy link
Copy Markdown
Contributor Author

I'm surprised too actually. I did some looking around briefly but I didn't noticed anything about sphinx overlooking those but my google foo probably wasn't very good.

Next push I put up for the json-docs branch I want to have a lint mode for this to run before actually outputting to files to help find things like this.

@daspecster daspecster force-pushed the fix-docstring-parse-errors branch from 86d9110 to eb72107 Compare May 5, 2016 02:34

metric.label.<label> = ends_with("<value>")

:type args: str

This comment was marked as spam.

@daspecster daspecster force-pushed the fix-docstring-parse-errors branch from eb72107 to 90eb8ce Compare May 5, 2016 14:34
@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented May 5, 2016

@daspecster Is this ready to go?

@daspecster
Copy link
Copy Markdown
Contributor Author

If you guys think so, I'm good to go on it.

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented May 5, 2016

LGTM. LMK if you can't merge.

@daspecster daspecster merged commit 77123bb into googleapis:master May 5, 2016
@daspecster daspecster deleted the fix-docstring-parse-errors branch May 5, 2016 20:01
parthea pushed a commit that referenced this pull request Nov 26, 2025
parthea pushed a commit that referenced this pull request Mar 6, 2026
* feat: support universe resolution

This PR wires up consumption of the universe_domain client option for
resolving the endpoint for constructing the BQ client.

Testing universes is not yet something we want to in this repo, so
validation was done out of band.

* formatting and testing

* conditionals for stale core

* formatting

* unused import
chalmerlowe pushed a commit that referenced this pull request Mar 26, 2026
…:` `D:` etc when application runs in Windows. (#1774)

skip downloading blobs whose name contain `":" ` eg: `C:` `D:` etc when
application runs in Windows.
chalmerlowe pushed a commit that referenced this pull request Mar 26, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.2-0.20251119154421-36c3e21ad3ac
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91
<details><summary>google-cloud-storage: 3.10.0</summary>

##
[3.10.0](googleapis/python-storage@v3.9.0...v3.10.0)
(2026-03-18)

### Features

* [Bucket Encryption Enforcement] add support for bucket encryption
enforcement config (#1742)
([2a6e8b00e4e6ff57460373f8e628fd363be47811](googleapis/python-storage@2a6e8b0))

### Perf Improvments

* [Rapid Buckets Reads] Use raw proto access for read resumption
strategy (#1764)
([14cfd61ce35365a409650981239ef742cdf375fb](googleapis/python-storage@14cfd61))
* [Rapid Buckets Benchmarks] init mp pool & grpc client once, use
os.sched_setaffinity (#1751)
([a9eb82c1b9b3c6ae5717d47b76284ed0deb5f769](googleapis/python-storage@a9eb82c))
* [Rapid Buckets Writes] don't flush at every append, results in bad
perf (#1746)
([ab62d728ac7d7be3c4fe9a99d72e35ead310805a](googleapis/python-storage@ab62d72))


### Bug Fixes

* [Windows] skip downloading blobs whose name contain `":" ` eg: `C:`
`D:` etc when application runs in Windows. (#1774)
([558198823ed51918db9c0137715d1e7f5b593975](googleapis/python-storage@5581988))
* [Path Traversal] Prevent path traversal in `download_many_to_path`
(#1768)
([700fec3bf7aa37bd5ea4b163cc3f9e8e6892bd5a](googleapis/python-storage@700fec3))
* [Rapid Buckets] pass token correctly, '&' instead of ',' (#1756)
([d8dd1e074d2431de9b45e0103181dce749a447a0](googleapis/python-storage@d8dd1e0))


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants