Skip to content

Moving Bigtable TestColumnRangeFilter within unit test file.#1335

Merged
dhermes merged 1 commit intogoogleapis:masterfrom
dhermes:re-order-TestColumnRangeFilter
Jan 7, 2016
Merged

Moving Bigtable TestColumnRangeFilter within unit test file.#1335
dhermes merged 1 commit intogoogleapis:masterfrom
dhermes:re-order-TestColumnRangeFilter

Conversation

@dhermes
Copy link
Copy Markdown
Contributor

@dhermes dhermes commented Dec 31, 2015

Doing this to match the order that the tested filters occur in row.py.

@tseaver Sorry this happened, I think it might've been caused by fly-by merges? I know you said the tests should come in the same order as the filters, which come in the same order as the fields in the proto spec.


To "verify" the order

$ cat gcloud/bigtable/row.py | grep -e '^class'
class Row(object):
class RowFilter(object):
class _BoolFilter(RowFilter):
class SinkFilter(_BoolFilter):
class PassAllFilter(_BoolFilter):
class BlockAllFilter(_BoolFilter):
class _RegexFilter(RowFilter):
class RowKeyRegexFilter(_RegexFilter):
class RowSampleFilter(RowFilter):
class FamilyNameRegexFilter(_RegexFilter):
class ColumnQualifierRegexFilter(_RegexFilter):
class TimestampRange(object):
class TimestampRangeFilter(RowFilter):
class ColumnRangeFilter(RowFilter):
class ValueRegexFilter(_RegexFilter):
class ValueRangeFilter(RowFilter):
class _CellCountFilter(RowFilter):
class CellsRowOffsetFilter(_CellCountFilter):
class CellsRowLimitFilter(_CellCountFilter):
class CellsColumnLimitFilter(_CellCountFilter):
class StripValueTransformerFilter(_BoolFilter):
class ApplyLabelFilter(RowFilter):
$
$
$ cat gcloud/bigtable/test_row.py | grep -e '^class'
class TestRow(unittest2.TestCase):
class Test_BoolFilter(unittest2.TestCase):
class TestSinkFilter(unittest2.TestCase):
class TestPassAllFilter(unittest2.TestCase):
class TestBlockAllFilter(unittest2.TestCase):
class Test_RegexFilter(unittest2.TestCase):
class TestRowKeyRegexFilter(unittest2.TestCase):
class TestRowSampleFilter(unittest2.TestCase):
class TestFamilyNameRegexFilter(unittest2.TestCase):
class TestColumnQualifierRegexFilter(unittest2.TestCase):
class TestTimestampRange(unittest2.TestCase):
class TestTimestampRangeFilter(unittest2.TestCase):
class TestColumnRangeFilter(unittest2.TestCase):
class TestValueRegexFilter(unittest2.TestCase):
class TestValueRangeFilter(unittest2.TestCase):
class Test_CellCountFilter(unittest2.TestCase):
class TestCellsRowOffsetFilter(unittest2.TestCase):
class TestCellsRowLimitFilter(unittest2.TestCase):
class TestCellsColumnLimitFilter(unittest2.TestCase):
class TestStripValueTransformerFilter(unittest2.TestCase):
class TestApplyLabelFilter(unittest2.TestCase):

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants