fix: [google-cloud-asset] fix ValueError in test__validate_universe_domain#12278
Merged
gcf-merge-on-green[bot] merged 5 commits intomainfrom Feb 7, 2024
Merged
Conversation
chore: update copyright year PiperOrigin-RevId: 604682846 Source-Link: googleapis/googleapis@e3b2f14 Source-Link: googleapis/googleapis-gen@fc7aaf1 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiJmYzdhYWYxZGI3MDE5M2Y5ZjM4NjA5N2Y4NzIwZGQ2OTk5MGJhNzBiIn0=
Contributor
|
The release PR should be merged first #12258 |
PiperOrigin-RevId: 604699565 Source-Link: googleapis/googleapis@cd3eabf Source-Link: googleapis/googleapis-gen@01f69ba Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiIwMWY2OWJhN2ExM2Q1OWU2ZjQ1ZTI0MzM1OWI5MWE2ZTg5NjIyMWY4In0=
ValueError in test__validate_universe_domain
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
vchudnov-g
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: fix ValueError in test__validate_universe_domain
docs: [google-cloud-asset] updated comments
chore: update copyright year
END_COMMIT_OVERRIDE
PiperOrigin-RevId: 604699565
Source-Link: googleapis/googleapis@cd3eabf
Source-Link: https://github.com/googleapis/googleapis-gen/commit/01f69ba7a13d59e6f45e243359b91a6e896221f8
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiIwMWY2OWJhN2ExM2Q1OWU2ZjQ1ZTI0MzM1OWI5MWE2ZTg5NjIyMWY4In0=
BEGIN_NESTED_COMMIT
docs: [google-cloud-asset] updated comments
chore: update copyright year
PiperOrigin-RevId: 604682846
Source-Link: googleapis/googleapis@e3b2f14
Source-Link: https://github.com/googleapis/googleapis-gen/commit/fc7aaf1db70193f9f386097f8720dd69990ba70b
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiJmYzdhYWYxZGI3MDE5M2Y5ZjM4NjA5N2Y4NzIwZGQ2OTk5MGJhNzBiIn0=
END_NESTED_COMMIT