This repository was archived by the owner on Mar 26, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
feat: add autogenerated snippets #845
Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
701476f
feat: change sampels to align with new design
busunkim96 c998993
feat: fulfill requirements for P0 snippetgen
busunkim96 6149983
fix: fix type issues
busunkim96 63a0509
fix: disable autogen snippets by default
busunkim96 793d108
fix: resolve mypy issues
busunkim96 be303df
fix: use trim_blocks and lstrip_blocks for jinja templates
busunkim96 c4f95cf
fix: fix more templates
busunkim96 1666d0a
fix: fix sample unit tests
busunkim96 23df2f3
test: add separate snippetgen session and basic golden snippet
busunkim96 a302db9
test: get existing unit tests to pass
busunkim96 093f931
chore: comment out manifest gen
busunkim96 2de6ac8
chore: tweak dummy ident in tests
busunkim96 ee1897c
feat: fill out basic snippets for other types
busunkim96 6b46aab
Merge branch 'master' into snippet-gen
busunkim96 0944178
fix: properly resolve merge conflict
busunkim96 a487f7d
chore: comment cleanup
busunkim96 351f0fe
Merge branch 'master' into snippet-gen
busunkim96 0ba949c
test: fix protoc installation, add snippetgen tests
busunkim96 0425783
Merge branch 'snippet-gen' of github.com:googleapis/gapic-generator-p…
busunkim96 769e06f
fix: fix style
busunkim96 e6224a6
chore: tell snippetgen to ignore this repo
busunkim96 0fce06c
fix: address review comments
busunkim96 3c3cb5a
fix: re-add templates on jinja files
busunkim96 b218789
chore: ignore test_output dir
busunkim96 cca0f54
test: add default host to gen sample spec test
busunkim96 ce309df
Merge branch 'master' into snippet-gen
software-dov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to change now so that snippets can be matched to products by the snippet tracker. @busunkim96 I've cc'ed you on a comment on the desgin doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! One thing I noticed is that the endpoint is declared at the service level. I guess in practice the endpoint is the same across all services in the same API? https://github.com/googleapis/googleapis/blob/ae5fb2884a296832c39867e8e8c81bbc72a32ce8/google/cloud/pubsublite/v1/subscriber.proto#L35