This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Add a test and impl for map field mock value#335
Merged
software-dov merged 1 commit intogoogleapis:masterfrom Mar 5, 2020
Merged
Add a test and impl for map field mock value#335software-dov merged 1 commit intogoogleapis:masterfrom
software-dov merged 1 commit intogoogleapis:masterfrom
Conversation
Protobuf map fields are special: under the hood they are implemnted as a sequence of generated type with two fields: 'key', whose type is the map key type, and 'value', whose type is the map value type. The user almost never wants to know about this implementation detail, and the python proto surface allows python dictionaries as rvalues when assigning to a mapped field. This change uses dict literals in generated unit tests where flattened parameters may refer to mapped fields.
software-dov
requested review from
arithmetic1728,
busunkim96,
crwilcox,
lukesneeringer and
yihanzhen
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 1395 1397 +2
Branches 288 289 +1
=====================================
+ Hits 1395 1397 +2
Continue to review full report at Codecov.
|
arithmetic1728
approved these changes
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf map fields are special: under the hood they are implemnted as a
sequence of generated type with two fields: 'key', whose type is the
map key type, and 'value', whose type is the map value type.
The user almost never wants to know about this implementation detail,
and the python proto surface allows python dictionaries as rvalues
when assigning to a mapped field.
This change uses dict literals in generated unit tests where flattened
parameters may refer to mapped fields. This allows certain generated unit tests to pass that previously wouldn't.