Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit 91d5917

Browse files
committed
Address comments: correct typing, remove debug logging and unused imports
1 parent 6b9712f commit 91d5917

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{% extends '_base.py.j2' %}
22

33
{% block content %}
4-
from typing import Callable, Dict, Sequence, Tuple
4+
from typing import Callable, Dict, Optional, Sequence, Tuple
55

66
from google.api_core import grpc_helpers # type: ignore
77
{%- if service.has_lro %}

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{% extends '_base.py.j2' %}
22

33
{% block content %}
4-
from typing import Awaitable, Callable, Dict, Sequence, Tuple
4+
from typing import Awaitable, Callable, Dict, Optional, Sequence, Tuple
55

66
from google.api_core import grpc_helpers_async # type: ignore
77
{%- if service.has_lro %}
@@ -47,7 +47,7 @@ class {{ service.grpc_asyncio_transport_name }}({{ service.name }}Transport):
4747
**kwargs) -> aio.Channel:
4848
"""Create and return a gRPC AsyncIO channel object.
4949
Args:
50-
address (Optionsl[str]): The host for the channel to use.
50+
address (Optional[str]): The host for the channel to use.
5151
credentials (Optional[~.Credentials]): The
5252
authorization credentials to attach to requests. These
5353
credentials identify this application to the service. If

tests/system/test_grpc_streams.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ def test_stream_stream_passing_dict(echo):
7979

8080
@pytest.mark.asyncio
8181
async def test_async_unary_stream_reader(async_echo):
82-
threading.current_thread(), asyncio.get_event_loop())
8382
content = 'The hail in Wales falls mainly on the snails.'
8483
call = await async_echo.expand({
8584
'content': content,

0 commit comments

Comments
 (0)