Address comments

Author: lidizheng

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2

@@ -108,7 +108,7 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
     def create_channel(cls,
                        host: str{% if service.host %} = '{{ service.host }}'{% endif %},
                        credentials: credentials.Credentials = None,
-                       scopes: Sequence[str] = None,
+                       scopes: Optional[Sequence[str]] = None,
                        **kwargs) -> grpc.Channel:
         """Create and return a gRPC channel object.
         Args:
@@ -118,7 +118,7 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
                 credentials identify this application to the service. If
                 none are specified, the client will attempt to ascertain
                 the credentials from the environment.
-            scopes (Sequence[str]): A optional list of scopes needed for this
+            scopes (Optional[Sequence[str]]): A optional list of scopes needed for this
                 service. These are only used when credentials are not specified and
                 are passed to :func:`google.auth.default`.
             kwargs (Optional[dict]): Keyword arguments, which are passed to the

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2

@@ -43,7 +43,7 @@ class {{ service.grpc_asyncio_transport_name }}({{ service.name }}Transport):
     def create_channel(cls,
                        host: str{% if service.host %} = '{{ service.host }}'{% endif %},
                        credentials: credentials.Credentials = None,
-                       scopes: Sequence[str] = None,
+                       scopes: Optional[Sequence[str]] = None,
                        **kwargs) -> aio.Channel:
         """Create and return a gRPC AsyncIO channel object.
         Args:
@@ -53,7 +53,7 @@ class {{ service.grpc_asyncio_transport_name }}({{ service.name }}Transport):
                 credentials identify this application to the service. If
                 none are specified, the client will attempt to ascertain
                 the credentials from the environment.
-            scopes (Sequence[str]): A optional list of scopes needed for this
+            scopes (Optional[Sequence[str]]): A optional list of scopes needed for this
                 service. These are only used when credentials are not specified and
                 are passed to :func:`google.auth.default`.
             kwargs (Optional[dict]): Keyword arguments, which are passed to the

tests/system/test_grpc_streams.py

@@ -79,31 +79,25 @@ def test_stream_stream_passing_dict(echo):
 
 @pytest.mark.asyncio
 async def test_async_unary_stream_reader(async_echo):
-    logging.debug('test_async_unary_stream_reader %s %s',
                   threading.current_thread(), asyncio.get_event_loop())
     content = 'The hail in Wales falls mainly on the snails.'
     call = await async_echo.expand({
         'content': content,
     }, metadata=metadata)
-    logging.debug('test_async_unary_stream_reader 2')
 
     # Consume the response and ensure it matches what we expect.
     # with pytest.raises(exceptions.NotFound) as exc:
     for ground_truth in content.split(' '):
-        logging.debug('test_async_unary_stream_reader 3')
         response = await call.read()
         assert response.content == ground_truth
-    logging.debug('test_async_unary_stream_reader 4')
     assert ground_truth == 'snails.'
 
-    logging.debug('test_async_unary_stream_reader 5')
     trailing_metadata = await call.trailing_metadata()
     assert trailing_metadata == metadata
 
 
 @pytest.mark.asyncio
 async def test_async_unary_stream_async_generator(async_echo):
-    logging.debug('test_async_unary_stream_async_generator')
     content = 'The hail in Wales falls mainly on the snails.'
     call = await async_echo.expand({
         'content': content,
@@ -123,7 +117,6 @@ async def test_async_unary_stream_async_generator(async_echo):
 
 @pytest.mark.asyncio
 async def test_async_stream_unary_iterable(async_echo):
-    logging.debug('test_async_stream_unary_iterable')
     requests = []
     requests.append(showcase.EchoRequest(content="hello"))
     requests.append(showcase.EchoRequest(content="world!"))
@@ -135,7 +128,6 @@ async def test_async_stream_unary_iterable(async_echo):
 
 @pytest.mark.asyncio
 async def test_async_stream_unary_async_generator(async_echo):
-    logging.debug('test_async_stream_unary_async_generator')
 
     async def async_generator():
         yield showcase.EchoRequest(content="hello")
@@ -148,7 +140,6 @@ async def async_generator():
 
 @pytest.mark.asyncio
 async def test_async_stream_unary_writer(async_echo):
-    logging.debug('test_async_stream_unary_writer')
     call = await async_echo.collect()
     await call.write(showcase.EchoRequest(content="hello"))
     await call.write(showcase.EchoRequest(content="world!"))
@@ -160,7 +151,6 @@ async def test_async_stream_unary_writer(async_echo):
 
 @pytest.mark.asyncio
 async def test_async_stream_unary_passing_dict(async_echo):
-    logging.debug('test_async_stream_unary_passing_dict')
     requests = [{'content': 'hello'}, {'content': 'world!'}]
     call = await async_echo.collect(iter(requests))
     response = await call
@@ -169,7 +159,6 @@ async def test_async_stream_unary_passing_dict(async_echo):
 
 @pytest.mark.asyncio
 async def test_async_stream_stream_reader_writier(async_echo):
-    logging.debug('test_async_stream_stream_reader_writier')
     call = await async_echo.chat(metadata=metadata)
     await call.write(showcase.EchoRequest(content="hello"))
     await call.write(showcase.EchoRequest(content="world!"))
@@ -187,7 +176,6 @@ async def test_async_stream_stream_reader_writier(async_echo):
 
 @pytest.mark.asyncio
 async def test_async_stream_stream_async_generator(async_echo):
-    logging.debug('test_async_stream_stream_async_generator')
 
     async def async_generator():
         yield showcase.EchoRequest(content="hello")
@@ -206,7 +194,6 @@ async def async_generator():
 
 @pytest.mark.asyncio
 async def test_async_stream_stream_passing_dict(async_echo):
-    logging.debug('test_async_stream_stream_passing_dict')
     requests = [{'content': 'hello'}, {'content': 'world!'}]
     call = await async_echo.chat(iter(requests), metadata=metadata)
 

tests/system/test_grpc_unary.py

@@ -14,7 +14,6 @@
 
 import pytest
 import asyncio
-import logging
 
 from google.api_core import exceptions
 from google.rpc import code_pb2