feat: import chisel in scalibrplugin#2772
Open
zhijie-yang wants to merge 4 commits intogoogle:mainfrom
Open
Conversation
another-rex
force-pushed
the
ROCKS-2010/add-chisel-scalibr-plugin
branch
from
64e6842 to
8b9aa1d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2772 +/- ##
==========================================
+ Coverage 79.06% 79.09% +0.02%
==========================================
Files 120 120
Lines 8154 8154
==========================================
+ Hits 6447 6449 +2
+ Misses 1324 1323 -1
+ Partials 383 382 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
another-rex
reviewed
May 7, 2026
Collaborator
another-rex
left a comment
another-rex
left a comment
There was a problem hiding this comment.
Can you added a e2e test by added a dockerfile that can build a chisel image, which can be scanned by scanner?
Author
|
Added as |
another-rex
force-pushed
the
ROCKS-2010/add-chisel-scalibr-plugin
branch
from
8a3f52e to
9168fb5
Compare
another-rex
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR imports the
os/chiselextractor from the osv-scalibr in thescalibrplugin/presets.goto enable the scanning of container images built with Chisel.The description of
Ubuntu chiseled packagesis added todocs/supported_languages_and_lockfiles.md, which corresponds to the changes of this PR.This PR expects no breaking changes nor regressive UX to be introduced to the OSV-Scanner.
Related pull requests
google/osv-scalibr#764
google/osv-scalibr#2018
P.S. I've run
make refresh-all REBUILD_IMAGES=trueto update the snapshots.FYI: @cjdcordeiro