feat: Add support for setting client URLs#4240
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4240 +/- ##
=======================================
Coverage 97.45% 97.46%
=======================================
Files 189 190 +1
Lines 19164 19178 +14
=======================================
+ Hits 18677 18691 +14
Misses 270 270
Partials 217 217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
LGTM.
Awaiting second LGTM+Approval from any other contributor to the repo before merging.
cc: @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode
|
Thank you, @munlicode! |
|
@gmlewis would it be possible to get a patch out for this? |
I may be able to do one this weekend. |
@stevehipwell - this is now available here: |
This PR adds support for setting the URLs without making changes to the path prefix as happens when using
github.WithEnterpriseURLs. This function is useful when mocking the GitHub API as without it all test servers need modifying to add the GHAS prefix.@gmlewis sorry but this might be worthy of a patch release, I discovered my oversight when I was wiring the new version up in the TF provider and while I was able to get the tests working I needed to modify the paths.