Handle FIXED32/FIXED64 as unsigned in ProtoCelValueConverter#1073
Open
andrewparmet wants to merge 1 commit into
Open
Handle FIXED32/FIXED64 as unsigned in ProtoCelValueConverter#1073andrewparmet wants to merge 1 commit into
andrewparmet wants to merge 1 commit into
Conversation
The CEL spec maps proto fixed32/fixed64 to CEL's uint. cel-java's checker (DescriptorMappings) and its legacy DescriptorMessageProvider path (ProtoAdapter) both correctly map them. The CelValue path via ProtoCelValueConverter.fromProtoMessageFieldToCelValue missed FIXED32/FIXED64 and fell through to normalizePrimitive, producing Integer/Long. Overload resolution at runtime then failed with "No matching overload" when the checker said uint but the runtime served a signed integer. Add the missing case labels alongside UINT32/UINT64 and extend the ProtoMessageValue test suite to cover fixed32/fixed64 selection.
3 tasks
l46kok
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CEL spec maps proto fixed32/fixed64 to CEL's uint. The CelValue path via ProtoCelValueConverter.fromProtoMessageFieldToCelValue lacks FIXED32/FIXED64 and falls through to normalizePrimitive, producing Integer/Long. Overload resolution at runtime then failed with "No matching overload" when the checker said uint but the runtime served a signed integer.
Add the missing case labels alongside UINT32/UINT64 and extend the ProtoMessageValue test suite to cover fixed32/fixed64 selection.