fix(web): handle TEXT modality for native-audio models (#4206)#5662
Open
paulxg12 wants to merge 1 commit into
Open
fix(web): handle TEXT modality for native-audio models (#4206)#5662paulxg12 wants to merge 1 commit into
paulxg12 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have read the Google CLA and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4206 — native-audio models fail when TEXT modality is explicitly requested via the ADK web server.
Root Cause
The
/run_liveWebSocket endpoint acceptedmodalitiesfrom query params without validating against model capabilities. When a user requestedTEXTmodality for a native-audio model (e.g.,gemini-live-2.5-flash-native-audio), the model failed since it only supportsAUDIO.Changes
adk_web_server.py: detect native-audio models in WebSocket handler and override modalities to["AUDIO"]runners.py: extended native-audio check to also correct explicitly-set["TEXT"]to["AUDIO"](previously only handledNonecase)Testing