fix(firestore): preserve update timestamps in list_sessions#5640
fix(firestore): preserve update timestamps in list_sessions#5640kkj333 wants to merge 2 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Populate Session.last_update_time from Firestore updateTime in list_sessions so session listings report accurate timestamps instead of always returning 0.0.
0a94def to
a9d4a60
Compare
|
The failing check is caused by the triaging workflow configuration, not by this PR changes.
Could a maintainer please update the triaging agent model (or rerun after fixing the workflow config)? |
|
Hi @kkj333 , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @Jacksunwei , can you please review this. |
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Closes: #5632
Problem
FirestoreSessionService.list_sessions()always setsSession.last_update_timeto0.0, even when Firestore documents containupdateTime.Solution
Use the same timestamp conversion logic as
get_session()inlist_sessions():updateTimeis adatetime, use.timestamp()float(updateTime)0.0when conversion failsThis keeps list responses consistent with
get_session()and preserves accurate update timestamps.Testing Plan
Unit Tests:
Updated tests:
test_list_sessions_with_user_idtest_list_sessions_without_user_idLocal pytest summary:
tests/unittests/integrations/firestore/test_firestore_session_service.py17 passedManual End-to-End (E2E) Tests:
Reproduced with a mocked Firestore client where session docs include
updateTime; before fixlast_update_timewas0.0, after fix it matches the Firestore value.Checklist