Skip to content

Update Package.swift#20

Merged
ncooke3 merged 1 commit into
mainfrom
nc/package-manifest-excludes
Apr 15, 2021
Merged

Update Package.swift#20
ncooke3 merged 1 commit into
mainfrom
nc/package-manifest-excludes

Conversation

@ncooke3

@ncooke3 ncooke3 commented Apr 15, 2021

Copy link
Copy Markdown
Member

Removes CHANGELOG.md from the excludes section of GoogleDataTransport target in package manifest.
This is done because the CHANGELOG.md was moved to root in #19.

Also removes the README.md from the excludes section of GoogleDataTransport target because that is also at root.

@ncooke3 ncooke3 requested review from paulb777 and removed request for paulb777 April 15, 2021 14:24
@google-oss-bot

Copy link
Copy Markdown

Coverage Report

Affected SDKs

  • GoogleDataTransport-ios-GoogleDataTransport.framework

    SDK overall coverage changed from 55.47% (a7b0ff5) to 45.78% (767e153) by -9.68%.

    Click to show coverage changes in 19 files.
    Filename Base (a7b0ff5) Head (767e153) Diff
    GDTCCTCompressionHelper.m 0.00% 87.14% +87.14%
    GDTCCTNanopbHelpers.m 0.00% 58.82% +58.82%
    GDTCCTUploadOperation.m 0.00% 91.17% +91.17%
    GDTCCTUploader.m 16.00% 90.29% +74.29%
    GDTCORAssert.m 88.89% 0.00% -88.89%
    GDTCORClock.m 85.26% 69.47% -15.79%
    GDTCORConsoleLogger.m 75.86% 20.69% -55.17%
    GDTCORDirectorySizeTracker.m 90.91% 63.64% -27.27%
    GDTCOREndpoints.m 100.00% 0.00% -100.00%
    GDTCOREvent+GDTCCTSupport.m 0.00% 37.56% +37.56%
    GDTCOREvent.m 97.70% 64.37% -33.33%
    GDTCORFlatFileStorage.m 91.22% 14.57% -76.65%
    GDTCORLifecycle.m 60.24% 42.17% -18.07%
    GDTCORPlatform.m 62.13% 52.32% -9.81%
    GDTCORRegistrar.m 69.50% 68.79% -0.71%
    GDTCORTransformer.m 90.99% 0.00% -90.99%
    GDTCORTransport.m 86.05% 0.00% -86.05%
    GDTCORUploadBatch.m 0.00% 100.00% +100.00%
    GDTCORUploadCoordinator.m 79.53% 61.40% -18.13%

Test Logs

@ncooke3 ncooke3 requested a review from paulb777 April 15, 2021 14:59
Comment thread Package.swift
Comment on lines -51 to -52
"CHANGELOG.md",
"README.md",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is a comment on line 41 above this target's declaration to "Restructure directory structure to simplify the excludes here."

Perhaps adding a folder Tests/ at root to contain all the test directories. Additionally, maybe ProtoSupport/ could be moved to root as well. This would eliminate the need for the excludes section entirely. Thoughts?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrating to the structure described at https://github.com/firebase/firebase-ios-sdk/blob/master/AddNewPod.md would be good. Any changes would need to be coordinated with google3 and copybara

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wingenroth Elsa Facebook

Comment thread Package.swift
Comment on lines -51 to -52
"CHANGELOG.md",
"README.md",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrating to the structure described at https://github.com/firebase/firebase-ios-sdk/blob/master/AddNewPod.md would be good. Any changes would need to be coordinated with google3 and copybara

@ncooke3 ncooke3 merged commit 4ced162 into main Apr 15, 2021
@ncooke3 ncooke3 deleted the nc/package-manifest-excludes branch April 15, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants