Skip to content

Improve readability issues#2

Merged
NTaylorMullen merged 2 commits intomainfrom
core
Apr 17, 2025
Merged

Improve readability issues#2
NTaylorMullen merged 2 commits intomainfrom
core

Conversation

@rakyll
Copy link
Contributor

@rakyll rakyll commented Apr 17, 2025

This is only the first change of many changes.

  • Remove redundant autogenerated comments
  • Use the recommended file name style
  • Use camelCase for variable names
  • Don't introduce submodules for relevant types
  • Don't introduce constants like modules, these are implementation details
  • Remove empty files

@rakyll rakyll requested a review from NTaylorMullen April 17, 2025 19:03
This is only the first change of many changes.

* Remove redundant autogenerated comments
* Use the recommended file name style
* Use camelCase for variable names
* Don't introduce submodules for relevant types
* Don't introduce constants like modules, these are implementation details
* Remove empty files
@NTaylorMullen NTaylorMullen merged commit ece8630 into main Apr 17, 2025
1 check passed
@rakyll rakyll deleted the core branch April 21, 2025 23:27
yewenchen pushed a commit to yewenchen/gemini-cli that referenced this pull request Jul 8, 2025
z23cc pushed a commit to z23cc/opengemini-cli that referenced this pull request Jul 10, 2025
hymjay0 added a commit to hymjay0/gemini-cli that referenced this pull request Jul 12, 2025
bishal-codepros pushed a commit to bishal-codepros/gemini-cli that referenced this pull request Jul 22, 2025
…vely function

- Combine initial abort check with depth check for efficiency
- Remove unnecessary abort check before fs.readdir (no async operations between checks)
- Add abort check after fs.readdir async operation where signal can actually change
- Remove abort check from inside for loop (synchronous operations only)
srithreepo pushed a commit that referenced this pull request Sep 4, 2025
…look for closingIssuesReferences instead of looking for the Issue ID in the body which can lead to wrong issues and labels being pulled in.
cocosheng-g added a commit to cocosheng-g/gemini-cli that referenced this pull request Oct 24, 2025
# This is the 1st commit message:

feat: Create BYOID auth client when detecting BYOID credentials

This change introduces a BYOID auth client that is created when
BYOID credentials are detected. It also refactors the code assist
server and setup to use the new AuthClient type.

# This is the commit message google-gemini#2:

resolve comments

# This is the commit message google-gemini#3:

load credentials only once and lazy load the client

# This is the commit message google-gemini#4:

use original method names

# This is the commit message google-gemini#5:

use original method names for getOauthClient

# This is the commit message google-gemini#6:

remove redundant test mock
aka76bm referenced this pull request in aka76bm/gemini-cli Oct 29, 2025
…m_and_yarn-fd296dbd23

chore(deps): bump vite from 7.1.9 to 7.1.11 in the npm_and_yarn group across 1 directory
A1cy added a commit to A1cy/HiveCodeCli that referenced this pull request Oct 29, 2025
CRITICAL SECURITY FIX - Removed publicly exposed AWS credentials

Files Changed:
- BEDROCK_SETUP.md: Replaced real credentials with placeholder examples
- QUICK_START.md: Replaced real credentials with placeholder examples

Security Impact:
- Removed AWS_ACCESS_KEY_ID: BedrockAPIKey-mzur-at-124737196430
- Removed AWS_SECRET_ACCESS_KEY (base64 encoded)

Action Required:
⚠️ USER MUST ROTATE AWS BEDROCK API KEYS IMMEDIATELY
⚠️ These credentials were exposed in commit 3ef2c7c
⚠️ Go to AWS Console → IAM → Bedrock API Keys → Rotate Keys

This commit removes the exposed secrets from documentation files.
Users should now use placeholder examples and replace with their own keys.

Fixes: GitHub Secret Scanning Alert google-gemini#2
@gvenugo3 gvenugo3 mentioned this pull request Mar 1, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants