Copy 4753d81554e9018e788f9e63d114aa50a5f7490e from copilot-sdk#220
Closed
edburns wants to merge 1 commit into
Closed
Copy 4753d81554e9018e788f9e63d114aa50a5f7490e from copilot-sdk#220edburns wants to merge 1 commit into
edburns wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ports a small change from the upstream copilot-sdk reference implementation, adjusting how the test harness locates the Copilot CLI entrypoint/binary.
Changes:
- Changed
TestUtil.findCliPath()lookup precedence to preferCOPILOT_CLI_PATHbefore searching the systemPATH. - Kept the fallback behavior that walks parent directories to find
nodejs/node_modules/@github/copilot/index.js.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/com/github/copilot/sdk/TestUtil.java | Reorders CLI path discovery to check COPILOT_CLI_PATH before PATH lookup. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
57
to
+66
| static String findCliPath() { | ||
| String copilotInPath = findCopilotInPath(); | ||
| if (copilotInPath != null) { | ||
| return copilotInPath; | ||
| } | ||
|
|
||
| String envPath = System.getenv("COPILOT_CLI_PATH"); | ||
| if (envPath != null && !envPath.isEmpty()) { | ||
| return envPath; | ||
| } | ||
|
|
||
| String copilotInPath = findCopilotInPath(); | ||
| if (copilotInPath != null) { | ||
| return copilotInPath; | ||
| } |
6 tasks
edburns
deleted the
edburns/sync-4753d8-from-copilot-sdk-to-copilot-sdk-java
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.