ref(ai): Rename generate_text to text_completion#5885
Merged
ericapisani merged 1 commit intomasterfrom Mar 26, 2026
Merged
Conversation
Rename the gen_ai.generate_text span op to gen_ai.text_completion across langchain and huggingface_hub integrations, aligning with updated naming conventions. Refs PY-2268 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Langchain
Bug Fixes 🐛Ci
Openai
Other
Internal Changes 🔧Langchain
Openai
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 13.51s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 50.00%. Project has 14412 uncovered lines. Files with missing lines (3)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 25.30% 30.20% +4.9%
==========================================
Files 189 189 —
Lines 20648 20648 —
Branches 6760 6760 —
==========================================
+ Hits 5223 6236 +1013
- Misses 15425 14412 -1013
- Partials 429 474 +45Generated by Codecov Action |
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
alexander-alderman-webb
approved these changes
Mar 26, 2026
Contributor
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the
gen_ai.generate_textspan op togen_ai.text_completionacross the langchain and huggingface_hub integrations, aligning with updated naming conventions.The constant
OP.GEN_AI_GENERATE_TEXTis renamed toOP.GEN_AI_TEXT_COMPLETION, and all span names, operation name data, and test assertions are updated accordingly. The huggingface_hub integration derives its span description dynamically from the op string, so no additional changes were needed there beyond the op reference.Refs PY-2268