Fix increment of trimHeadFrames being lost again#1224
Merged
kamilogorek merged 1 commit intogetsentry:masterfrom Feb 14, 2018
leth:trimheadagain
Merged
Fix increment of trimHeadFrames being lost again#1224kamilogorek merged 1 commit intogetsentry:masterfrom leth:trimheadagain
kamilogorek merged 1 commit intogetsentry:masterfrom
leth:trimheadagain
Conversation
Contributor
|
Nice find! It was very hard to spot. Can you please move the comment about why do this just above the incrementation itself? Thanks! |
Contributor
|
Thanks! |
Contributor
Author
|
@kamilogorek Any chance of a release soon :) This would really help us improve our error reports! |
Contributor
|
Ah, excuse me for the delay @leth. Released as |
Contributor
Author
|
No problem! Thanks! |
This was referenced Mar 15, 2018
chargome
added a commit
that referenced
this pull request
Mar 20, 2026
Partially fixes Dependabot alert #1224. Updates the @azure/core-xml transitive dependency chain to fast-xml-parser 5.5.8 (patched for CVE-2026-33349). AWS SDK and Langchain chains require upstream updates. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chargome
added a commit
that referenced
this pull request
Mar 23, 2026
…9918) Partially fixes Dependabot alert #1224. Updates the @azure/core-xml transitive dependency chain to fast-xml-parser 5.5.8 (patched for CVE-2026-33349). AWS SDK and Langchain chains require upstream updates. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
logaretm
pushed a commit
that referenced
this pull request
Mar 24, 2026
…9918) Partially fixes Dependabot alert #1224. Updates the @azure/core-xml transitive dependency chain to fast-xml-parser 5.5.8 (patched for CVE-2026-33349). AWS SDK and Langchain chains require upstream updates. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found another place where the value wasn't being passed on as you might expect!