Conversation
…eManagerWrapper Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
…tion - Use cache key as span description instead of cache name, matching the spec and other SDKs (Python, JavaScript) - Skip instrumentation for putIfAbsent since we cannot know if a write actually occurred; override to bypass default get()+put() delegation - Wrap valueLoader Callable in get(key, Callable) to detect cache hit/miss instead of always reporting hit=true - Update tests to match new behavior Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…uration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sentry Build Distribution
|
adinauer
force-pushed
the
feat/cache-tracing
branch
from
b2dbb4d to
7735a81
Compare
Sentry Build Distribution
|
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use Caffeine as the cache provider instead of a plain ConcurrentMapCacheManager. Spring Boot auto-configures CaffeineCacheManager when Caffeine is on the classpath, so the explicit CacheManager bean is no longer needed. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 304.04 ms | 370.33 ms | 66.29 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
| b3d8889 | 371.33 ms | 426.24 ms | 54.92 ms |
| 55aaf9b | 336.43 ms | 364.14 ms | 27.71 ms |
| 6727e14 | 337.22 ms | 373.94 ms | 36.71 ms |
| f634d01 | 359.58 ms | 433.88 ms | 74.30 ms |
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
| bbc35bb | 324.88 ms | 425.73 ms | 100.85 ms |
| f064536 | 327.04 ms | 405.35 ms | 78.31 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| 55aaf9b | 0 B | 0 B | 0 B |
| 6727e14 | 1.58 MiB | 2.28 MiB | 718.64 KiB |
| f634d01 | 1.58 MiB | 2.10 MiB | 533.40 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| f064536 | 1.58 MiB | 2.20 MiB | 633.90 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
Sentry Build Distribution
|
Like putIfAbsent, these are conditional writes that may be no-ops. Emitting a cache.put span for them would be misleading.
startChild can return a NoOp span (e.g. when span limit is reached). Skip instrumentation in that case to avoid unnecessary work.
removeAll() with no args removes all entries, which is semantically equivalent to clear(). Use cache.flush instead of cache.remove. The keyed removeAll(Set) remains cache.remove.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…on-name feat(spring): [Cache Tracing 12] Add db.operation.name attribute to cache spans
…-conditional-ops feat(spring): [Cache Tracing 13] Instrument putIfAbsent, replace, and getAndReplace
…it-detection fix(spring): [Cache Tracing 14] Fix cache hit detection for typed get and fix jcache docs link
…ific-ops ref(spring): [Cache Tracing 15] Use method-specific span operations for cache spans
…span-helpers ref(jcache): [Cache Tracing 16] Merge startSpan helpers into shared core method
…tion-key ref(cache): [Cache Tracing 17] Move operation attribute to centralized CACHE_OPERATION_KEY
feat(cache): [Cache Tracing 18] Add cache.write boolean span attribute
…-description fix(jcache): [Cache Tracing 19] Use comma-joined keys as span description for bulk operations
…tants ref(cache): [Cache Tracing 20] Remove _KEY suffix from cache SpanDataConvention constants
…ouble-call fix(spring): [Cache Tracing 21] Fix get(key, type) double-call in SentryCacheWrapper
…m-test fix(samples): [Cache Tracing 22] Fix cache evict system test to match actual span op
…w-changes test(cache): [Cache Tracing 23] Add missing cache key assertions and use exact equals
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
adinauer
commented
Mar 23, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Set cache.write based on delegate.invalidate() result instead of always true. This keeps span data aligned with Spring's invalidate semantics when no entries were present. Add tests in spring, spring-jakarta, and spring-7 wrappers to cover the false return path and assert cache.write is false. Co-Authored-By: Claude <noreply@anthropic.com>
8 tasks
…cache-write fix(spring): [Cache Tracing 24] Track invalidate cache.write accurately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Cache Tracing)
Collection PR for the Cache Tracing stack. Squash-merge this once all stack PRs are merged.
📜 Description
Adds auto-instrumentation for Spring's
Cacheabstraction, producingcache.get,cache.put,cache.remove, andcache.flushspans per the Sentry cache module spec.💡 Motivation and Context
Closes #4120
💚 How did you test it?
See individual PRs for test details.
📝 Checklist
sendDefaultPIIis enabled.