fix: include API endpoint in error messages for better diagnostics (CLI-BS)#500
Merged
fix: include API endpoint in error messages for better diagnostics (CLI-BS)#500
Conversation
…LI-BS) The generic 'API request failed: 404 Not Found' from apiRequest() doesn't identify which endpoint failed, making it hard to diagnose. This affects 24 users (CLI-BS) across issue view, whoami, and log list. Two changes: 1. Pass the endpoint parameter to ApiError in apiRequest() so it's captured in telemetry 2. Show the endpoint in ApiError.format() so users see which API path failed — helping them identify self-hosted endpoint gaps, wrong org/project context, or missing features
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1068 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.66% 95.68% +0.02%
==========================================
Files 180 180 —
Lines 24700 24704 +4
Branches 0 0 —
==========================================
+ Hits 23629 23636 +7
- Misses 1071 1068 -3
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The generic
API request failed: 404 Not FoundfromapiRequest()doesn't identify which endpoint failed. This affects 24 users (CLI-BS) across issue view, whoami, and log list commands.Fix
Two changes:
apiRequest()so it's captured in telemetryApiError.format()so users see which API path failed:This helps users identify:
/auth/on older instances)