Skip to content

fix: include API endpoint in error messages for better diagnostics (CLI-BS)#500

Merged
BYK merged 1 commit intomainfrom
fix/cli-bs-generic-404
Mar 20, 2026
Merged

fix: include API endpoint in error messages for better diagnostics (CLI-BS)#500
BYK merged 1 commit intomainfrom
fix/cli-bs-generic-404

Conversation

@BYK
Copy link
Copy Markdown
Member

@BYK BYK commented Mar 20, 2026

Problem

The generic API request failed: 404 Not Found from apiRequest() doesn't identify which endpoint failed. This affects 24 users (CLI-BS) across issue view, whoami, and log list commands.

Fix

Two changes:

  1. Pass endpoint to ApiError in apiRequest() so it's captured in telemetry
  2. Show endpoint in ApiError.format() so users see which API path failed:
API request failed: 404 Not Found
  Endpoint: /auth/
  {"detail": "Not found."}

This helps users identify:

  • Self-hosted endpoints that don't exist (e.g., /auth/ on older instances)
  • Wrong org/project context causing resource-not-found
  • Missing features (e.g., logs endpoint not enabled)

…LI-BS)

The generic 'API request failed: 404 Not Found' from apiRequest()
doesn't identify which endpoint failed, making it hard to diagnose.
This affects 24 users (CLI-BS) across issue view, whoami, and log list.

Two changes:
1. Pass the endpoint parameter to ApiError in apiRequest() so it's
   captured in telemetry
2. Show the endpoint in ApiError.format() so users see which API
   path failed — helping them identify self-hosted endpoint gaps,
   wrong org/project context, or missing features
@github-actions
Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (telemetry) Track TTY vs non-TTY invocations via metric by betegon in #482
  • Dynamic cache-backed shell completions with fuzzy matching by BYK in #465

Bug Fixes 🐛

  • (project) Fallback to org listing when bare slug matches an organization by betegon in #475
  • Include API endpoint in error messages for better diagnostics (CLI-BS) by BYK in #500
  • Enrich 403 on org listing with token scope guidance (CLI-89) by BYK in #498
  • Add 400 suggestions to org-all issue list path (CLI-BY) by BYK in #497
  • Lowercase project slug in issue arg parsing (CLI-C8) by BYK in #496
  • Enrich short ID 404 with org context and suggestions (CLI-A1) by BYK in #494
  • Suggest similar projects when project not found in org (CLI-C0) by BYK in #493
  • Event 404 hint should suggest different project, not repeat failing command by BYK in #492
  • Enrich event 404 errors with retention and format suggestions (CLI-6F) by BYK in #491
  • Add actionable suggestions for 400 Bad Request on issue list (CLI-BM, CLI-7B) by BYK in #489
  • Detect issue short IDs passed to issue list (CLI-C3) by BYK in #488
  • Add Glob.match() polyfill + improve auto-detect diagnostics (CLI-7T) by BYK in #487
  • Add org-slug pre-check to dispatchOrgScopedList (CLI-9A) by BYK in #485

Internal Changes 🔧

  • (issue) Skip getProject round-trip in project-search resolution by betegon in #473
  • (resolve) Carry project data through resolution to eliminate redundant getProject calls by BYK in #486
  • (telemetry) Convert is_tty metric to span tag by betegon in #499
  • HTTP latency optimizations — diagnostics, cache warming, concurrency limits by BYK in #490
  • Switch from @sentry/bun to @sentry/node-core/light (~170ms startup savings) by BYK in #474
  • Regenerate skill files by github-actions[bot] in b7b240ec

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Codecov Results 📊

126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 1068 uncovered lines.
✅ Project coverage is 95.68%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
infrastructure.ts 99.51% ⚠️ 1 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    95.66%    95.68%    +0.02%
==========================================
  Files          180       180         —
  Lines        24700     24704        +4
  Branches         0         0         —
==========================================
+ Hits         23629     23636        +7
- Misses        1071      1068        -3
- Partials         0         0         —

Generated by Codecov Action

@BYK BYK merged commit 6a60754 into main Mar 20, 2026
22 checks passed
@BYK BYK deleted the fix/cli-bs-generic-404 branch March 20, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant