fix(setup): suppress agent skills and welcome messages on upgrade#328
Merged
fix(setup): suppress agent skills and welcome messages on upgrade#328
Conversation
During upgrades, suppress noisy output that is only relevant for fresh installs: - Agent skills: Only print 'Installed to' on first creation, not 'Updated' on every subsequent run (same pattern as completions) - Welcome message: Only show 'Get started' info when --install places a binary for the first time (fresh install), not when overwriting an existing binary (upgrade) - Remove 'Setup complete!' trailing message — the upgrade command already prints its own success message Behavior summary: Fresh install (--install, no existing binary): welcome + getting started Upgrade (--install, binary exists): binary path only Package manager upgrade (no --install): silent Manual re-run: silent
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Trace
Other
Bug Fixes 🐛Api
Formatters
Setup
Other
Internal Changes 🔧Api
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 2434 passed | Total: 2434 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 3137 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.23% 81.23% —%
==========================================
Files 121 121 —
Lines 16711 16711 —
Branches 0 0 —
==========================================
+ Hits 13574 13574 —
- Misses 3137 3137 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Suppresses noisy output during upgrades that is only relevant for fresh installs. Follows up on #326 which did the same for shell completions.
What's suppressed on upgrade
Agent skills: Updated <path>Get started:welcome block--installwhen binary already existsSetup complete!How it works
createdpattern as completions — only print on first creation, silently update on subsequent runshandleInstall()now checks if the binary already exists before installation. Returnscreated: booleanto distinguish fresh install from upgradeSuccessfully upgraded to <version>Behavior table
--install, no existing binary)--install, binary exists)--install)--quietTests
--installwith pre-existing binary