Skip to content

fix(setup): suppress agent skills and welcome messages on upgrade#328

Merged
BYK merged 1 commit intomainfrom
fix/setup-suppress-upgrade-noise
Mar 3, 2026
Merged

fix(setup): suppress agent skills and welcome messages on upgrade#328
BYK merged 1 commit intomainfrom
fix/setup-suppress-upgrade-noise

Conversation

@BYK
Copy link
Copy Markdown
Member

@BYK BYK commented Mar 3, 2026

Summary

Suppresses noisy output during upgrades that is only relevant for fresh installs. Follows up on #326 which did the same for shell completions.

What's suppressed on upgrade

Message When suppressed
Agent skills: Updated <path> Subsequent runs (file already exists)
Get started: welcome block --install when binary already exists
Setup complete! Always (upgrade command prints its own message)

How it works

  • Agent skills: Same created pattern as completions — only print on first creation, silently update on subsequent runs
  • Welcome message: handleInstall() now checks if the binary already exists before installation. Returns created: boolean to distinguish fresh install from upgrade
  • Setup complete: Removed entirely — the upgrade command already prints Successfully upgraded to <version>

Behavior table

Scenario Output
Fresh install (--install, no existing binary) Binary path + welcome + getting started
Curl upgrade (--install, binary exists) Binary path only
npm/pnpm upgrade (no --install) Silent
Any + --quiet Silent

Tests

  • Updated 3 existing tests for new behavior
  • Added 2 new tests: upgrade suppression for agent skills and --install with pre-existing binary

During upgrades, suppress noisy output that is only relevant for
fresh installs:

- Agent skills: Only print 'Installed to' on first creation, not
  'Updated' on every subsequent run (same pattern as completions)
- Welcome message: Only show 'Get started' info when --install places
  a binary for the first time (fresh install), not when overwriting
  an existing binary (upgrade)
- Remove 'Setup complete!' trailing message — the upgrade command
  already prints its own success message

Behavior summary:
  Fresh install (--install, no existing binary): welcome + getting started
  Upgrade (--install, binary exists): binary path only
  Package manager upgrade (no --install): silent
  Manual re-run: silent
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Trace

Other

  • (api) Add --data/-d flag and auto-detect JSON body in fields by BYK in #320
  • (formatters) Render all terminal output as markdown by BYK in #297
  • (issue-list) Global limit with fair distribution, compound cursor, and richer progress by BYK in #306

Bug Fixes 🐛

Api

  • Use numeric project ID to avoid "not actively selected" error by betegon in #312
  • Use limit param for issues endpoint page size by BYK in #309
  • Auto-correct ':' to '=' in --field values with a warning by BYK in #302

Formatters

  • Expand streaming table to fill terminal width by betegon in #314
  • Fix HTML entities and escaped underscores in table output by betegon in #313

Setup

  • Suppress agent skills and welcome messages on upgrade by BYK in #328
  • Suppress shell completion messages on upgrade by BYK in #326

Other

  • (ci) Generate JUnit XML to silence codecov-action warnings by BYK in #300
  • (nightly) Push to GHCR from artifacts dir so layer titles are bare filenames by BYK in #301
  • (region) Resolve DSN org prefix at resolution layer by BYK in #316
  • (test) Handle 0/-0 in getComparator anti-symmetry property test by BYK in #308
  • (trace-logs) Timestamp_precise is a number, not a string by BYK in #323

Internal Changes 🔧

Api

  • Upgrade @sentry/api to 0.21.0, remove raw HTTP pagination workarounds by BYK in #321
  • Wire listIssuesPaginated through @sentry/api SDK for type safety by BYK in #310

Other

  • (craft) Add sentry-release-registry target by BYK in #325

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2026

Codecov Results 📊

2434 passed | Total: 2434 | Pass Rate: 100% | Execution Time: 0ms

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +2
Passed Tests 📈 +2
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 3137 uncovered lines.
✅ Project coverage is 81.23%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
setup.ts 98.21% ⚠️ 5 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    81.23%    81.23%        —%
==========================================
  Files          121       121         —
  Lines        16711     16711         —
  Branches         0         0         —
==========================================
+ Hits         13574     13574         —
- Misses        3137      3137         —
- Partials         0         0         —

Generated by Codecov Action

@BYK BYK marked this pull request as ready for review March 3, 2026 17:00
@BYK BYK merged commit b4d4666 into main Mar 3, 2026
20 checks passed
@BYK BYK deleted the fix/setup-suppress-upgrade-noise branch March 3, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant