Fix IndexOutOfBoundsException in GitUtil.getRepositoryURL when no remotes configured

[Copilot]

Recording fails with IndexOutOfBoundsException in GitUtil.getRepositoryURL when the git repository has no remotes — the fallback path of remotes.get(0) is hit unconditionally on a potentially empty list.

Changes

• Guard against empty remotes list — return null early if remotes.isEmpty() instead of falling through to remotes.get(0)
• Guard against empty URIs list — return null if the selected remote has no URIs configured
• Use orElseGet over orElse — avoids eagerly evaluating remotes.get(0) when "origin" is present
• getRepositoryURL() returns null instead of "" when no URL is available, allowing callers to distinguish "no remote" from an actual empty string
• AppMapSerializer.writeMetadata() only writes the repository key when getRepositoryURL() returns a non-null value

// Before
List<URIish> uris = originConfig.isPresent() ? originConfig.get().getURIs() : remotes.get(0).getURIs();
return uris.get(0).toASCIIString(); // throws if remotes or uris is empty

// After
if (remotes.isEmpty()) return null;
RemoteConfig remote = originConfig.orElseGet(() -> remotes.get(0));
List<URIish> uris = remote.getURIs();
if (uris.isEmpty()) return null;
return uris.get(0).toASCIIString();

[kgilpin]

getRepositoryURL should be modified to return String | null, or to return String[] which might be empty, and caller sites updated accordingly. @copilot

[Copilot]

getRepositoryURL should be modified to return String | null, or to return String[] which might be empty, and caller sites updated accordingly. @copilot

Done in 5956839. getRepositoryURL() now returns null (instead of "") when no remotes are configured, a remote has no URIs, or an exception occurs. The caller in AppMapSerializer.writeMetadata() now only writes the repository key when the returned value is non-null.

[dividedmind]

I've added tests and changed the agent to look for the git repo based on the appmap.yml instead of the working directory (which is IMO less surprising and allowed me to add unit tests without ungodly complications — it seems JVM doesn't have a concept of the working directory or how to change it).

@kgilpin please take a look; if it looks good, you can go ahead and squash merge (there's a bunch of wip commits here); please make sure to use proper fix: ... commit message subject for semantic-release. Or just let me know and I'll do it :)

[kgilpin]

Looks good - I have been using this in my benchmark

[appland-release]

🎉 This PR is included in version 1.30.1 🎉

The release is available on:

• v1.30.1
• GitHub release

Your semantic-release bot 📦🚀