Skip to content

[GEP-28] Add InternalIPs to CreateMachineResponse#322

Merged
kon-angelo merged 1 commit into
gardener:masterfrom
jamand:feat/add-internal-ip-to-machine-status
Oct 24, 2025
Merged

[GEP-28] Add InternalIPs to CreateMachineResponse#322
kon-angelo merged 1 commit into
gardener:masterfrom
jamand:feat/add-internal-ip-to-machine-status

Conversation

@jamand

@jamand jamand commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

How to categorize this PR?
/kind enhancement
/platform openstack

What this PR does / why we need it:

Server InternalIPs are now returned on created Machines, so that they may be used by gardenadm bootstrap (GEP-28). This is useful when the already provided hostname field (in the Machine status.addresses) is not resolvable, e.g. due to cloud provider specific settings.

Which issue(s) this PR fixes:
Fixes #321

Special notes for your reviewer:
/cc @timebertt @maboehm

  • Currently relies on gardener/machine-controller-manager@52f840e to avoid container crashes, requires a new release.
  • Added a new test case (to check having a pool with multiple internal IPs) + extended happy path.
  • Tested on own environment (with Garden, multiple Seeds, Shoots on the gardener/gardener v1.128.4 version), using the Medium touch scenario: in a virtual cluster the Machine resource is created and the InternalIP is set in the Machine Status.

Release note:

When calling CreateMachine() the method now returns the internal IPs of the server in the Addresses field. 

@jamand jamand requested review from a team as code owners October 13, 2025 14:17
@CLAassistant

CLAassistant commented Oct 13, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ghost ghost added the needs/review Needs review label Oct 13, 2025
@ghost

ghost commented Oct 13, 2025

Copy link
Copy Markdown

Thank you @jamand for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@ghost ghost added kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2025
@timebertt

Copy link
Copy Markdown
Member

cc @kon-angelo @hebelsan can you help us get a review here?

@kon-angelo

Copy link
Copy Markdown
Contributor

/assign

@ghost ghost assigned kon-angelo Oct 20, 2025
kon-angelo
kon-angelo previously approved these changes Oct 20, 2025

@kon-angelo kon-angelo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had already looked at the change but forgot to post the review 😅 .

I assume there is no other way to get a more "structured" response from the addresses field. I also had a look at the client but I didn't think anything better.

@kon-angelo

Copy link
Copy Markdown
Contributor

/needs rebase

@ghost ghost added the needs/rebase Needs git rebase label Oct 20, 2025
@jamand

jamand commented Oct 21, 2025

Copy link
Copy Markdown
Contributor Author

@kon-angelo Thanks for the Review! In order to remove the current dependency on this particular commit (already on main) I would need a new (patch) release of https://github.com/gardener/machine-controller-manager. I would then do a rebase.
Can you do that or who should I ask?

Also to your point with the "structured" response from the addresses field: I'm also not super happy about it, here the OpenStack API Reference is equally vague with type "object" and the description consult with OpenStack Networking API for up-to-date information.

@jamand jamand requested a review from kon-angelo October 24, 2025 07:19
@kon-angelo

Copy link
Copy Markdown
Contributor

Let me see about the update/rebase. Otherwise the pr is lgtm

@kon-angelo

Copy link
Copy Markdown
Contributor

#327 should do it I take it ? @jamand

@jamand

jamand commented Oct 24, 2025

Copy link
Copy Markdown
Contributor Author

@kon-angelo Yup, I'm doing the rebase

Server InternalIPs are returned on created Machines, so that they may
be used by gardenadm bootstrap (GEP-28) in case the already provided hostname
(Machine Status field) is not reachable (cloud provider specific).
@jamand jamand force-pushed the feat/add-internal-ip-to-machine-status branch from 83aaaff to 5b26085 Compare October 24, 2025 12:49
@jamand

jamand commented Oct 24, 2025

Copy link
Copy Markdown
Contributor Author

@kon-angelo Done

@kon-angelo kon-angelo merged commit d185d21 into gardener:master Oct 24, 2025
11 checks passed
@ghost ghost added the status/closed Issue is closed (either delivered or triaged) label Oct 24, 2025
jamand added a commit to stackitcloud/machine-controller-manager-provider-openstack that referenced this pull request Oct 28, 2025
jamand added a commit to stackitcloud/machine-controller-manager-provider-openstack that referenced this pull request Oct 28, 2025
timebertt pushed a commit to stackitcloud/machine-controller-manager-provider-openstack that referenced this pull request Oct 28, 2025
@gardener-prow gardener-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2026
@ghost ghost added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement, improvement, extension needs/rebase Needs git rebase needs/review Needs review needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. platform/openstack OpenStack platform/infrastructure size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GEP-28] Extend CreateMachineResult to include InternalIP

4 participants