@W-9531534@: Tests are now configured to run with the LTS node version.#431
Closed
jfeingold35 wants to merge 7 commits into
Closed
@W-9531534@: Tests are now configured to run with the LTS node version.#431jfeingold35 wants to merge 7 commits into
jfeingold35 wants to merge 7 commits into
Conversation
| - "63:74:04:09:64:97:7e:c6:9b:45:c0:5e:d3:7e:40:ed" | ||
| - checkout | ||
|
|
||
| unix_node_upgrade: |
Contributor
There was a problem hiding this comment.
Can these be put into separate scripts? Similar to the smoke tests?
| DESIRED_VERSION=v`npx n ls-remote ${VERSION_ALIAS}` | ||
|
|
||
| # Install the desired version. | ||
| curl -sSL "https://nodejs.org/dist/${DESIRED_VERSION}/node-${DESIRED_VERSION}-linux-x64.tar.xz" | sudo tar --strip-components=2 -xJ -C /usr/local/bin/ node-${DESIRED_VERSION}-linux-x64/bin/node |
Contributor
There was a problem hiding this comment.
Can you doc what -sSL does? I had to look it up, at first it could appear to be skipping SSL.
| VERSION_ALIAS=$1 | ||
|
|
||
| # Install `n`, a module that we can use to resolve the node alias into an actual version. | ||
| npm install n |
Contributor
There was a problem hiding this comment.
We should file a 3pp for this.
Contributor
Author
|
Superceded by #436 |
aruntyagiTutu
added a commit
that referenced
this pull request
Mar 9, 2026
Updates @salesforce/code-analyzer-eslint-engine dependency to use the newly published version 0.40.2 which includes critical parser bug fixes. Changes: - @salesforce/code-analyzer-eslint-engine: 0.40.1 → 0.40.2 What's in eslint-engine 0.40.2: - Fixed parser not configured when both JS and LWC base configs disabled - Fixed TypeScript parser when TS base config disabled - Added minimal parser fallback for all scenarios - Comprehensive documentation for parser selection strategy This ensures LWC files with decorators, TypeScript files with type annotations, and React JSX files all parse correctly regardless of which base configs are enabled or disabled. Related: - code-analyzer-core PR #431 (merged) - Fixes W-21462752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.