[Fix] time.clock() deprecated in Python 3.8#123
Merged
fogleman merged 1 commit intofogleman:masterfrom Dec 14, 2020
marco97pa:master
Merged
[Fix] time.clock() deprecated in Python 3.8#123fogleman merged 1 commit intofogleman:masterfrom marco97pa:master
fogleman merged 1 commit intofogleman:masterfrom
marco97pa:master
Conversation
Replaced all calls to time.clock() with time.perf_counter(). time.clock() has been removed from the time module in Python 3.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced all calls to
time.clock()withtime.perf_counter().time.clock()has been removed from thetimemodule in Python 3.8.This PR closes #108 and makes the app executable again on Python 3.8+
Tested on my Windows machine with Python 3.8
Before the fix, the app was crashing unexpectedly with the following Traceback: