Skip to content

node: fix invalid YAML syntax in pnpm v11 storeDir setup#540

Merged
bbhtt merged 1 commit into
flatpak:masterfrom
lullabyX:fix/node-pnpm-v11-storedir-yaml-syntax
Jun 7, 2026
Merged

node: fix invalid YAML syntax in pnpm v11 storeDir setup#540
bbhtt merged 1 commit into
flatpak:masterfrom
lullabyX:fix/node-pnpm-v11-storedir-yaml-syntax

Conversation

@lullabyX

@lullabyX lullabyX commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

With --pnpm-store-version v11, _add_pnpm_config() writes storeDir=$PWD/... to pnpm-workspace.yaml which is invalid YAML, crashes pnpm:
[ERROR] can not read a block mapping entry; a multiline key may not be an implicit key

Fix: =: . The else branch (.npmrc + store-dir=) is correct as-is and unchanged.

Introduced in #537. Reference comment

@lullabyX lullabyX requested a review from bbhtt as a code owner June 6, 2026 23:01
@github-actions github-actions Bot added the node label Jun 6, 2026
@lullabyX

lullabyX commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

hey @bbhtt
The node CI failures are unrelated to this PR. Looks like the failures are in the Electron integration test, which doesn't go through the pnpm path

FAILED tests/test_providers.py::test_special_electron[ProviderFactoryType.NPM-24] - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/flatpak-builder-tools/flatpak-builder-tools/cache/.flatpak-builder/build/module/node_modules/electron/dist/version'
FAILED tests/test_providers.py::test_special_electron[ProviderFactoryType.YARN-24] - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/flatpak-builder-tools/flatpak-builder-tools/cache/.flatpak-builder/build/module/node_modules/electron/dist/version'

@bbhtt bbhtt force-pushed the fix/node-pnpm-v11-storedir-yaml-syntax branch from ee0364b to 74956c0 Compare June 7, 2026 03:06
@bbhtt bbhtt merged commit ac5a296 into flatpak:master Jun 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants