cargo: Embed resolved manifest in generated sources#349
Conversation
|
@tim77 @sebastian-de @muelli Can you please test this patched cargo generator with the apps you maintain (Veloren, Lapce and Delta Chat respectively (these three are known to be the most complex rust apps on Flathub and heavily use packages from git))? |
|
Hi @gasinvein, thanks for reaching out. This is probably because https://github.com/lapce/wasi-experimental-http uses a subdirectory called |
d684bd7 to
5fe210a
Compare
|
@sebastian-de Thanks for the feedback. I've updated the PR (force-pushed), can you try again with these changes, please? |
Cargo with `inherit-workspace` feature requires workspace packages Cargo.toml's to be resolved when using vendored sources, because the workspace manifest won't be available when building them.
5fe210a to
c27b0cc
Compare
|
@gasinvein with your latest change the script runs fine and generates valid sources. I also did a test build of the Lapce Flatpak with the new script - works! |
seems to work for delta chat :) |
|
Ok, thanks, then I believe it should be good to go. |
Cargo with
inherit-workspacefeature requires workspace packages Cargo.toml's to be resolved when using vendored sources, because the workspace manifest won't be available when building them.Fixes #348
See also rust-lang/cargo#11414