Skip to content

Highlight matched nodes in the stack chart when searching#5935

Open
fatadel wants to merge 1 commit intofirefox-devtools:mainfrom
fatadel:highlight-node-1818
Open

Highlight matched nodes in the stack chart when searching#5935
fatadel wants to merge 1 commit intofirefox-devtools:mainfrom
fatadel:highlight-node-1818

Conversation

@fatadel
Copy link
Copy Markdown
Contributor

@fatadel fatadel commented Apr 2, 2026

Closes #1818.

When a search string is active, draw a BLUE_60 border around stack chart boxes whose function name matches. Ancestor call nodes in the path of a match also get a thinner border to highlight the full call node path.


Before reviewing the code changes, I would like you to have a look visually and tell me if that is what you want to see 🤓

This is the profile from the STR of the original issue with the changes of this PR.

  When a search string is active, draw a BLUE_60 border around stack chart
  boxes whose function name matches. Ancestor call nodes in the path of a
  match also get a thinner border to highlight the full call node path.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.46%. Comparing base (c886717) to head (fdb1a1e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5935      +/-   ##
==========================================
+ Coverage   85.45%   85.46%   +0.01%     
==========================================
  Files         321      321              
  Lines       32139    32171      +32     
  Branches     8850     8775      -75     
==========================================
+ Hits        27463    27495      +32     
  Misses       4241     4241              
  Partials      435      435              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel fatadel requested review from canova and julienw April 2, 2026 16:01
@mstange
Copy link
Copy Markdown
Contributor

mstange commented Apr 2, 2026

Before reviewing the code changes, I would like you to have a look visually and tell me if that is what you want to see 🤓

Looks acceptable to me visually. Not super pretty but good enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When searching in the stack chart, the matched nodes should be highlighted

2 participants