Update the hovered item when panning any viewport canvas#5903
Open
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
Open
Update the hovered item when panning any viewport canvas#5903mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
Contributor
Author
|
Hmm, fails tests. And the shallow equal stuff seems fishy. And the unsafe also seems fishy. |
428514e to
1244dfc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5903 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 321 321
Lines 32139 32141 +2
Branches 8850 8763 -87
=======================================
+ Hits 27463 27465 +2
Misses 4241 4241
Partials 435 435 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
The test failure was because we were using the initial offset values 0,0 to make something hovered before the mouse even entered the canvas. Fixed now. The other things I mentioned are pre-existing and we don't need to fix them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview
Fixes #3807.