Skip to content

Update the hovered item when panning any viewport canvas#5903

Open
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange:push-lqlsmpskomzw
Open

Update the hovered item when panning any viewport canvas#5903
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange:push-lqlsmpskomzw

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented Mar 20, 2026

@mstange mstange requested a review from canova March 20, 2026 19:56
@mstange mstange marked this pull request as draft March 20, 2026 20:03
@mstange
Copy link
Copy Markdown
Contributor Author

mstange commented Mar 20, 2026

Hmm, fails tests. And the shallow equal stuff seems fishy. And the unsafe also seems fishy.

@canova canova removed their request for review March 24, 2026 13:08
@mstange mstange force-pushed the push-lqlsmpskomzw branch from 428514e to 1244dfc Compare April 4, 2026 14:48
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.45%. Comparing base (c886717) to head (1244dfc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/shared/chart/Canvas.tsx 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5903   +/-   ##
=======================================
  Coverage   85.45%   85.45%           
=======================================
  Files         321      321           
  Lines       32139    32141    +2     
  Branches     8850     8763   -87     
=======================================
+ Hits        27463    27465    +2     
  Misses       4241     4241           
  Partials      435      435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange
Copy link
Copy Markdown
Contributor Author

mstange commented Apr 4, 2026

Hmm, fails tests. And the shallow equal stuff seems fishy. And the unsafe also seems fishy.

The test failure was because we were using the initial offset values 0,0 to make something hovered before the mouse even entered the canvas. Fixed now. The other things I mentioned are pre-existing and we don't need to fix them here.

@mstange mstange marked this pull request as ready for review April 4, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't click the flame graph after scrolling unless I also move the mouse

1 participant