This repository was archived by the owner on May 27, 2026. It is now read-only.
Fix to issue #648#739
Merged
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
ChrisCummins
left a comment
ChrisCummins
left a comment
Contributor
There was a problem hiding this comment.
Hi @nluu175! Thanks for the PR. I left some comments inline 🙂
Cheers,
Chris
Comment on lines
+35
to
+44
| # def step(self, action: ActionType, **kwargs): | ||
| # assert ( | ||
| # self._elapsed_steps is not None | ||
| # ), "Cannot call env.step() before calling reset()" | ||
| # observation, reward, done, info = self.env.step(action, **kwargs) | ||
| # self._elapsed_steps += 1 | ||
| # if self._elapsed_steps >= self._max_episode_steps: | ||
| # info["TimeLimit.truncated"] = not done | ||
| # done = True | ||
| # return observation, reward, done, info |
Contributor
There was a problem hiding this comment.
You can delete these lines. Don't submit commented-out code
| # done = True | ||
| # return observation, reward, done, info | ||
|
|
||
| def multistep(self, actions: Iterable[ActionType], **kwargs): |
Contributor
There was a problem hiding this comment.
Suggested change
| def multistep(self, actions: Iterable[ActionType], **kwargs): | |
| def multistep(self, actions: Iterable[ActionType], **kwargs): | |
| actions = list(actions) |
I would suggest forcing the conversion of actions to a list here, since there could be a subtle bug if actions is an iterator, as it would break the len(actions) below.
| fkd.close() | ||
|
|
||
|
|
||
| # @pytest.mark.xfail(strict=True, reason="https://github.com/facebookresearch/CompilerGym/issues/648") |
Contributor
There was a problem hiding this comment.
don't commit commented out code
| # @pytest.mark.xfail(strict=True, reason="https://github.com/facebookresearch/CompilerGym/issues/648") | ||
| def test_time_limit(env: LlvmEnv): | ||
| """Check CycleOverBenchmarks does not break TimeLimit""" | ||
| env = TimeLimit(env, max_episode_steps=1) |
Contributor
There was a problem hiding this comment.
I would suggest testing with max_episode_steps=3, so that you can test that done is False for the first two calls to step().
| env.reset() | ||
| _, _, done, _ = env.step(0) | ||
|
|
||
| assert done |
Contributor
There was a problem hiding this comment.
Suggested change
| assert done | |
| assert done | |
| assert info["TimeLimit.truncated"], info |
Best to also test the reason why done=True.
Contributor
Author
|
Hi @ChrisCummins . Thanks for the feedbacks. I'll resolve those and as soon as possible! |
Codecov Report
@@ Coverage Diff @@
## development #739 +/- ##
===============================================
- Coverage 88.79% 88.77% -0.03%
===============================================
Files 129 129
Lines 7854 7855 +1
===============================================
- Hits 6974 6973 -1
- Misses 880 882 +2
|
Contributor
|
Changes LGTM, thanks! I will merge once CI tests pass. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #648