Cancel animation when a custom Timeline is used#35567
Merged
sebmarkbage merged 1 commit intofacebook:mainfrom Jan 20, 2026
Merged
Cancel animation when a custom Timeline is used#35567sebmarkbage merged 1 commit intofacebook:mainfrom
sebmarkbage merged 1 commit intofacebook:mainfrom
Conversation
The clean up function of the custom timeline doesn't necessarily clean up the animation. Just the timeline's internal state.
github-actions
Bot
added
the
React Core Team
|
Comparing: d343c39...817bd79 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 20, 2026
[diff facebook/react@41b3e9a6...d2908752](facebook/react@41b3e9a...d290875) <details> <summary>React upstream changes</summary> - facebook/react#35567 - facebook/react#35566 - facebook/react#35565 - facebook/react#35564 - facebook/react#35559 - facebook/react#35556 </details>
github-actions Bot
pushed a commit
to shlomiNugarker/react
that referenced
this pull request
Jan 20, 2026
Follow up to facebook#35559. The clean up function of the custom timeline doesn't necessarily clean up the animation. Just the timeline's internal state. This affects Firefox which doesn't support ScrollTimeline so uses the polyfill's custom timeline. DiffTrain build for [d290875](facebook@d290875)
github-actions Bot
pushed a commit
to shlomiNugarker/react
that referenced
this pull request
Jan 20, 2026
Follow up to facebook#35559. The clean up function of the custom timeline doesn't necessarily clean up the animation. Just the timeline's internal state. This affects Firefox which doesn't support ScrollTimeline so uses the polyfill's custom timeline. DiffTrain build for [d290875](facebook@d290875)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #35559.
The clean up function of the custom timeline doesn't necessarily clean up the animation. Just the timeline's internal state.
This affects Firefox which doesn't support ScrollTimeline so uses the polyfill's custom timeline.