Clarify useActionState async non-transition warning#32207
Merged
sophiebits merged 1 commit intofacebook:mainfrom Jan 24, 2025
Merged
Clarify useActionState async non-transition warning#32207sophiebits merged 1 commit intofacebook:mainfrom
sophiebits merged 1 commit intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
|
Comparing: ae9017ceabb2a36a04c249ad5342e0b1af3e1a54...598f10bce1e3730ddc64ffeba36bf12a6dd61232 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
approved these changes
Jan 24, 2025
| '`action` prop, or dispatch manually inside `startTransition`', | ||
| 'An async function with useActionState was called outside of a transition. ' + | ||
| 'This is likely not what you intended (for example, isPending will not update ' + | ||
| 'correctly). Either call the returned function inside startTransition, or pass it ' + |
Collaborator
There was a problem hiding this comment.
"dispatch manually" vs new "call the returned function" is much clearer 👍🏻
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
#28491 (comment) DiffTrain build for [b65afdd](b65afdd)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
#28491 (comment) DiffTrain build for [b65afdd](b65afdd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#28491 (comment)