Better NEXT_MAJOR support for RN flags#28583
Merged
rickhanlonii merged 3 commits intofacebook:mainfrom Mar 22, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__NEXT_MAJOR__value in the RN flags doesn't make sense because:a) The flags are for the next RN major, since it only impacts the renderers
b) The flags are off, so they're not currently in the next major, they need enabled
c) the flag script didn't support it
This PR adds two aliases to the RN file:
__TODO_NEXT_RN_MAJOR__: flags that need enabled before the next RN major.__NEXT_RN_MAJOR__: flags that have been enabled since the last RN major.These values will need to be manually kept up to date when we cut a RN version, but once RN switches to the canary build and aligns all the flags, this entire file can be deleted.
Script screen
Notably, I added a TODO value and a legend that prints at the end of the script: