Guard against unmounted components when accessing public instances on Fabric (#27687)#41452
Closed
rubennorte wants to merge 1 commit into
Closed
Guard against unmounted components when accessing public instances on Fabric (#27687)#41452rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
… Fabric (facebook#27687) Summary: ## Summary This fixes an error in `getPublicInstanceFromInstanceHandle` where we throw an error when trying to access the public instance from the fiber of an unmounted component. This shouldn't throw but return `null` instead. ## How did you test this change? Updated unit tests. Before: <img width="969" alt="Screenshot 2023-11-10 at 15 26 14" src="https://github.com/facebook/react/assets/117921/ea161616-2775-4fab-8d74-da4bef48d09a"> After: <img width="1148" alt="Screenshot 2023-11-10 at 15 28 37" src="https://github.com/facebook/react/assets/117921/db18b918-b6b6-4925-9cfc-3b4b2f3ab92d"> DiffTrain build for commit facebook/react@6b3834a. Reviewed By: tyao1 Differential Revision: D51203276 Pulled By: tyao1
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51203276 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
… Fabric (facebook#27687) (facebook#41452) Summary: ## Summary This fixes an error in `getPublicInstanceFromInstanceHandle` where we throw an error when trying to access the public instance from the fiber of an unmounted component. This shouldn't throw but return `null` instead. ## How did you test this change? Updated unit tests. Before: <img width="969" alt="Screenshot 2023-11-10 at 15 26 14" src="https://github.com/facebook/react/assets/117921/ea161616-2775-4fab-8d74-da4bef48d09a"> After: <img width="1148" alt="Screenshot 2023-11-10 at 15 28 37" src="https://github.com/facebook/react/assets/117921/db18b918-b6b6-4925-9cfc-3b4b2f3ab92d"> DiffTrain build for commit facebook/react@6b3834a. Test Plan: Sandcastle tests Reviewed By: tyao1 Differential Revision: D51203276 Pulled By: tyao1
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
… Fabric (facebook#27687) (facebook#41452) Summary: ## Summary This fixes an error in `getPublicInstanceFromInstanceHandle` where we throw an error when trying to access the public instance from the fiber of an unmounted component. This shouldn't throw but return `null` instead. ## How did you test this change? Updated unit tests. Before: <img width="969" alt="Screenshot 2023-11-10 at 15 26 14" src="https://github.com/facebook/react/assets/117921/ea161616-2775-4fab-8d74-da4bef48d09a"> After: <img width="1148" alt="Screenshot 2023-11-10 at 15 28 37" src="https://github.com/facebook/react/assets/117921/db18b918-b6b6-4925-9cfc-3b4b2f3ab92d"> DiffTrain build for commit facebook/react@6b3834a. Test Plan: Sandcastle tests Reviewed By: tyao1 Differential Revision: D51203276 Pulled By: tyao1
|
This pull request was successfully merged by @rubennorte in e0aa9ab. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
@rubennorte merged this pull request in e0aa9ab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
This fixes an error in
getPublicInstanceFromInstanceHandlewhere wethrow an error when trying to access the public instance from the fiber
of an unmounted component. This shouldn't throw but return
nullinstead.
How did you test this change?
Updated unit tests.
Before:
After:
DiffTrain build for commit facebook/react@6b3834a.
Reviewed By: tyao1
Differential Revision: D51203276
Pulled By: tyao1