Skip to content

Remove ComponentLookup#21379

Merged
NullVoxPopuli merged 2 commits intomainfrom
copilot/remove-component-lookup
May 7, 2026
Merged

Remove ComponentLookup#21379
NullVoxPopuli merged 2 commits intomainfrom
copilot/remove-component-lookup

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 6, 2026

ComponentLookup has been dead code for a long time — its componentFor/layoutFor methods are unused by the framework — yet it was still registered into every application and engine as component-lookup:main and exported publicly via @ember/-internals/views.

Changes

  • Deleted packages/@ember/-internals/views/lib/component_lookup.ts
  • Removed export of ComponentLookup from @ember/-internals/views/index.ts
  • Removed import and registry.register('component-lookup:main', ComponentLookup) from @ember/engine/index.ts
  • Updated engine and application tests to drop the now-removed component-lookup:main registration assertions
  • Cleaned up package.json module map and lib/index.js dist file list entries

Copilot AI linked an issue May 6, 2026 that may be closed by this pull request
Agent-Logs-Url: https://github.com/emberjs/ember.js/sessions/fe31834a-56a0-415a-aa83-b24faef03508

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove component-lookup from application code Remove ComponentLookup May 6, 2026
Copilot AI requested a review from NullVoxPopuli May 6, 2026 23:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

📊 Size report

Tarball size1.2 MB1.2 MB

dist/dev   -0.03%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/@ember/-internals/views/lib/component_lookup.js 402 B / 187 B
./packages/@ember/engine/index.js 15.3 kB / 3.6 kB -0.9%↓15.1 kB / -0.61%↓3.6 kB
Total (Includes all files) 2 MB / 484.8 kB -0.03%↓2 MB / -0.05%↓484.5 kB

dist/prod   -0.03%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/@ember/-internals/views/lib/component_lookup.js 402 B / 187 B
./packages/@ember/engine/index.js 14.4 kB / 3.4 kB -0.96%↓14.3 kB / -0.58%↓3.4 kB
Total (Includes all files) 1.8 MB / 444.1 kB -0.03%↓1.8 MB / -0.05%↓443.8 kB

smoke-tests/v2-app-hello-world-template/dist   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 243.6 kB / 66.8 kB 243.6 kB / 66.8 kB

🤖 This report was automatically generated by wyvox/pkg-size

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review May 7, 2026 04:28
@NullVoxPopuli NullVoxPopuli merged commit ad2dee3 into main May 7, 2026
40 of 42 checks passed
@NullVoxPopuli NullVoxPopuli deleted the copilot/remove-component-lookup branch May 7, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove component-lookup

3 participants