fix(providers-evm-rpc): await semaphore acquire in latest_block#2008
Merged
fix(providers-evm-rpc): await semaphore acquire in latest_block#2008
Conversation
The `latest_block` method was missing `.await` on `self.limiter.acquire()`, causing the future to be dropped immediately without ever acquiring a permit. Rate limiting was silently bypassed for every `latest_block` call.
LNSD
reviewed
Mar 23, 2026
| }; | ||
| let _permit = self.limiter.acquire(); | ||
| let _permit = self.limiter.acquire().await.map_err(|_| { | ||
| LatestBlockError::from(anyhow::anyhow!("rate limiter semaphore closed")) |
Contributor
There was a problem hiding this comment.
Can we remove the anyhow dependency from the client crates?
LNSD
approved these changes
Mar 23, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
LGTM ✅
The comment above is not a blocker. But we should address it asap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
latest_blockmethod was missing.awaitonself.limiter.acquire(), causing the future to be dropped immediately without ever acquiring a permit. Rate limiting was silently bypassed for everylatest_blockcall.