Open
Conversation
lunar CLI v1.0.11 -> v1.1.1, lunar-ci-agent v1.1.0 -> v1.1.2
📝 WalkthroughWalkthroughDocumentation updates to self-hosted agent installation guides across three skills, pinning Lunar CLI version from v1.0.11 to v1.1.1 and lunar-ci-agent version from v1.1.0 to v1.1.2 in download URLs and Dockerfile examples. Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
skills/lunar-policy/docs/install/agent-self-hosted.md (1)
22-22: Keep label and link intent aligned.Line 22 uses “latest” while linking to a fixed version binary. Consider updating wording or URL for consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lunar-policy/docs/install/agent-self-hosted.md` at line 22, The link label "Download the latest `lunar-ci-agent`" is inconsistent with the hard-coded URL that points to v1.1.2; update either the text or the URL so intent matches: either change the label to "Download `lunar-ci-agent` v1.1.2" (or interpolated version variable) or change the URL to the latest release endpoint (remove the fixed v1.1.2 segment) so the link truly points to the latest binary; ensure you update the markdown text surrounding "Download the latest `lunar-ci-agent`" and the href accordingly.skills/lunar-sql/docs/install/agent-self-hosted.md (1)
22-22: Clarify “latest” wording vs pinned URL target.Line 22 says “latest
lunar-ci-agent”, but the link points to a version-pinned artifact (v1.1.2). Consider either linking to/releases/latestor changing text to “Downloadlunar-ci-agentv1.1.2”.Suggested doc tweak
- [Download the latest `lunar-ci-agent`](https://github.com/earthly/lunar-ci-agent-dist/releases/download/v1.1.2/lunar-ci-agent-linux-amd64): + [Download `lunar-ci-agent` v1.1.2](https://github.com/earthly/lunar-ci-agent-dist/releases/download/v1.1.2/lunar-ci-agent-linux-amd64):🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lunar-sql/docs/install/agent-self-hosted.md` at line 22, Update the wording or the link for the "latest `lunar-ci-agent`" line to avoid mismatch: either change the text to explicitly state the pinned version (e.g., "Download `lunar-ci-agent` v1.1.2") to match the existing versioned URL, or replace the versioned download URL with the releases/latest redirect (e.g., use the GitHub /releases/latest path) so the "latest" label is accurate; adjust the anchor text "lunar-ci-agent" and the URL in the same line accordingly.skills/lunar-collector/docs/install/agent-self-hosted.md (1)
22-22: Minor docs clarity: avoid “latest” for pinned artifact links.Line 22 currently mixes “latest” wording with a fixed-version URL; aligning these would reduce ambiguity.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lunar-collector/docs/install/agent-self-hosted.md` at line 22, The line saying "Download the latest `lunar-ci-agent`" is inconsistent with the pinned URL that includes v1.1.2; update the wording to match the fixed artifact version (e.g., "Download lunar-ci-agent v1.1.2") or alternatively change the link to a truly latest/unversioned release URL—adjust the text "Download the latest `lunar-ci-agent`" to explicitly reference "v1.1.2" (the version in the URL) so the copy and the link are aligned.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@skills/lunar-collector/docs/install/agent-self-hosted.md`:
- Line 22: The line saying "Download the latest `lunar-ci-agent`" is
inconsistent with the pinned URL that includes v1.1.2; update the wording to
match the fixed artifact version (e.g., "Download lunar-ci-agent v1.1.2") or
alternatively change the link to a truly latest/unversioned release URL—adjust
the text "Download the latest `lunar-ci-agent`" to explicitly reference "v1.1.2"
(the version in the URL) so the copy and the link are aligned.
In `@skills/lunar-policy/docs/install/agent-self-hosted.md`:
- Line 22: The link label "Download the latest `lunar-ci-agent`" is inconsistent
with the hard-coded URL that points to v1.1.2; update either the text or the URL
so intent matches: either change the label to "Download `lunar-ci-agent` v1.1.2"
(or interpolated version variable) or change the URL to the latest release
endpoint (remove the fixed v1.1.2 segment) so the link truly points to the
latest binary; ensure you update the markdown text surrounding "Download the
latest `lunar-ci-agent`" and the href accordingly.
In `@skills/lunar-sql/docs/install/agent-self-hosted.md`:
- Line 22: Update the wording or the link for the "latest `lunar-ci-agent`" line
to avoid mismatch: either change the text to explicitly state the pinned version
(e.g., "Download `lunar-ci-agent` v1.1.2") to match the existing versioned URL,
or replace the versioned download URL with the releases/latest redirect (e.g.,
use the GitHub /releases/latest path) so the "latest" label is accurate; adjust
the anchor text "lunar-ci-agent" and the URL in the same line accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4ae8b574-a342-4b38-a10b-c31c0599b254
📒 Files selected for processing (3)
skills/lunar-collector/docs/install/agent-self-hosted.mdskills/lunar-policy/docs/install/agent-self-hosted.mdskills/lunar-sql/docs/install/agent-self-hosted.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by CodeRabbit