Skip to content

fix(e6): escape lone apostrophes in literals under FIX_QUOTE_ESCAPES #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkaunlaky-e6 merged 3 commits into from
May 11, 2026
Merged

fix(e6): escape lone apostrophes in literals under FIX_QUOTE_ESCAPES #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae1e77c
fix(e6): escape lone apostrophes in literals when FIX_QUOTE_ESCAPES i…
tkaunlaky-e6 May 11, 2026
e70320f
test(e6): add cases for Databricks double-quoted strings with apostro…
tkaunlaky-e6 May 11, 2026
f7af361
Update comments for clarity in test_e6.py
tkaunlaky-e6 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sqlglot/dialects/e6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1648,6 +1648,8 @@ def escape_str(self, text: str, escape_backslash: bool = True) -> str:
When FIX_QUOTE_ESCAPES is not enabled, falls back to base behavior.
"""
if os.getenv("FIX_QUOTE_ESCAPES", "False").lower() == "true":
if "''" not in text:
return super().escape_str(text, escape_backslash)
if self.dialect.ESCAPED_SEQUENCES:
to_escaped = self.dialect.ESCAPED_SEQUENCES
text = "".join(
Expand Down
14 changes: 14 additions & 0 deletions tests/dialects/test_e6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3636,4 +3636,18 @@ def transpile(sql):
"""INSERT INTO espresso_gold_test.e6data_test.story_items_dml_clone (story_item_id, story_id, item_data) SELECT UUID(), '54e04514-5aad-4e24-9189-2b369970e70b', '[{"Title":"ROCKIN'' AROUND THE CHRISTMAS TREE","Artist":"BRENDA LEE"},{"Title":"SHAKIN'' STEVENS"},{"Title":"DO THEY KNOW IT''S CHRISTMAS"},{"Title":"IT''S THE MOST WONDERFUL TIME"},{"Title":"SANTA CAN''T YOU HEAR ME"},{"Title":"NOBODY''S GIRL"},{"Title":"SANTA CLAUS IS COMIN'' TO TOWN"},{"Title":"DON''T CALL"},{"Title":"NOBODY''S SON"}]'""",
)

# 5. Databricks double-quoted string with apostrophe inside (variant A)
self.assertEqual(
transpile("""SELECT "SCARLET'S WALK (2023 REMASTER)" AS name"""),
r"""SELECT 'SCARLET\'S WALK (2023 REMASTER)' AS name""",
)

# 6. Full INSERT — double-quoted string with apostrophe in map() value
self.assertEqual(
transpile(
"""INSERT INTO espresso_gold_prod.global.ui_my_fav_charts_main (selection, module_name) VALUES (map('product_id', '51605207', 'name', "SCARLET'S WALK (2023 REMASTER)", 'class_dbid', ''), 'Product-Summary')"""
),
r"""INSERT INTO espresso_gold_prod.global.ui_my_fav_charts_main (selection, module_name) VALUES (map('product_id', '51605207', 'name', 'SCARLET\'S WALK (2023 REMASTER)', 'class_dbid', ''), 'Product-Summary')""",
)

os.environ["FIX_QUOTE_ESCAPES"] = "False"
Loading