fix: reduce potential menu bar memory growth from oversized collapsed widths#344
Merged
Merged
Conversation
sdenike
added a commit
to sdenike/hidden-revived
that referenced
this pull request
Apr 23, 2026
Adds the non-overlapping pieces of huynguyenh's PR dwarvesf#335 on top of rm335's PR dwarvesf#346. Handles the biggest leak source (NSLayoutConstraint retention when NSImageViews were recreated 9-10 times per toggle). - Deactivate NSLayoutConstraints before removing views in NSStackView.removeAllSubViews (prevents constraint retention of removed NSImageViews — primary leak source on macOS Sequoia/Tahoe) - Extend StatusBarController.deinit to invalidate timer and remove the always-hidden NSStatusItem - Change toggleStatusBarIfNeeded to only create the always-hidden status item when it doesn't already exist, instead of tearing down and recreating on every .alwayHideToggle notification Combined with the widest-display collapse-length calc in dwarvesf#354 and the bounded-length work in dwarvesf#344, this should resolve the runaway memory growth reported in upstream dwarvesf#326, dwarvesf#336, dwarvesf#351, dwarvesf#352. Co-Authored-By: huynguyenh <hoanghuy2908@gmail.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sdenike
pushed a commit
to sdenike/hidden-revived
that referenced
this pull request
Apr 29, 2026
sdenike
added a commit
to sdenike/hidden-revived
that referenced
this pull request
Apr 29, 2026
Adds the non-overlapping pieces of huynguyenh's PR dwarvesf#335 on top of rm335's PR dwarvesf#346. Handles the biggest leak source (NSLayoutConstraint retention when NSImageViews were recreated 9-10 times per toggle). - Deactivate NSLayoutConstraints before removing views in NSStackView.removeAllSubViews (prevents constraint retention of removed NSImageViews — primary leak source on macOS Sequoia/Tahoe) - Extend StatusBarController.deinit to invalidate timer and remove the always-hidden NSStatusItem - Change toggleStatusBarIfNeeded to only create the always-hidden status item when it doesn't already exist, instead of tearing down and recreating on every .alwayHideToggle notification Combined with the widest-display collapse-length calc in dwarvesf#354 and the bounded-length work in dwarvesf#344, this should resolve the runaway memory growth reported in upstream dwarvesf#326, dwarvesf#336, dwarvesf#351, dwarvesf#352. Co-Authored-By: huynguyenh <hoanghuy2908@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses high-memory reports (see #326) by removing oversized status item collapse widths that can trigger expensive menu bar layout behavior on newer macOS versions.
Closes #343.
Root cause hypothesis
StatusBarControllerused very large hardcoded collapse lengths (10000) for status items when hiding sections.On newer macOS builds, oversized status item geometry appears to cause pathological layout/repaint work, which aligns with reports of Hidden consuming multiple GB of RAM.
What changed
max(500, min(screenWidth + 200, 4000))NSApplication.didChangeScreenParametersNotificationdeinitnow removes observers.NSStatusItemfromNSStatusBarbefore replacing/nilling.Why this is safe
Validation notes
I couldn’t run full
xcodebuildin this environment because full Xcode isn’t installed (only Command Line Tools). Please validate on macOS 15/26 with Activity Monitor after repeated collapse/expand + auto-hide cycles.