Add scalar FixedTimeEquals overload#127826
Merged
vcsjones merged 1 commit intodotnet:mainfrom May 6, 2026
Merged
Conversation
Implement the approved CryptographicOperations overload for comparing a span against a scalar byte value in fixed time, and use it for the Windows X25519 all-zero shared secret check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new scalar overload for CryptographicOperations.FixedTimeEquals so callers can compare a buffer against a repeated byte value without materializing a second span. In this codebase, that primarily simplifies constant-time zero-buffer checks such as the Windows X25519 shared-secret validation path.
Changes:
- Added
CryptographicOperations.FixedTimeEquals(ReadOnlySpan<byte> source, byte value)to the implementation and ref assembly. - Replaced the Windows X25519 all-zero shared-secret check to use the new scalar overload instead of a hard-coded zero span.
- Expanded
FixedTimeEqualstests to cover scalar true/false cases and verify both overloads retain the required method implementation flags.
Show a summary per file
| File | Description |
|---|---|
src/libraries/System.Security.Cryptography/tests/FixedTimeEqualsTests.cs |
Adds scalar overload coverage and updates the method-attribute reflection test. |
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X25519DiffieHellmanImplementation.Windows.cs |
Switches the all-zero shared-secret check to the new scalar overload. |
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CryptographicOperations.cs |
Implements and documents the new public scalar overload. |
src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs |
Exposes the new public API in the ref assembly. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
MihaZupan
approved these changes
May 5, 2026
This was referenced May 6, 2026
bartonjs
approved these changes
May 6, 2026
Member
Author
|
/ba-g failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127584