Skip to content

[mono] Handle nint/nuint in Crc32 and ArmBase intrinsic dispatch #127787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kotlarmilos wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −4
Open

[mono] Handle nint/nuint in Crc32 and ArmBase intrinsic dispatch #127787

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95c9862
[mono][aot] Handle MONO_TYPE_I/U for Crc32 and ArmBase intrinsics
kotlarmilos May 5, 2026
68516d0
Merge branch 'main' into fix/mono-aot-crc32-nuint
kotlarmilos May 7, 2026
2006c04
Merge branch 'main' into fix/mono-aot-crc32-nuint
kotlarmilos May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/mono/mono/mini/simd-intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4951,8 +4951,8 @@ emit_arm64_intrinsics (
(arg0_type == MONO_TYPE_I8 ? OP_ARM64_SMULH : OP_ARM64_UMULH), 0, arg0_type, fsig, args);
case SN_ReverseElementBits:
return emit_simd_ins_for_sig (cfg, klass,
(is_64bit ? OP_XOP_I8_I8 : OP_XOP_I4_I4),
(is_64bit ? INTRINS_BITREVERSE_I64 : INTRINS_BITREVERSE_I32),
(arg0_i32 ? OP_XOP_I4_I4 : OP_XOP_I8_I8),
(arg0_i32 ? INTRINS_BITREVERSE_I32 : INTRINS_BITREVERSE_I64),
arg0_type, fsig, args);
case SN_Yield: {
MonoInst* ins;
Expand All @@ -4973,14 +4973,26 @@ emit_arm64_intrinsics (
case SN_ComputeCrc32C: {
IntrinsicId op = (IntrinsicId)0;
gboolean is_c = info->id == SN_ComputeCrc32C;
gboolean is_8byte_data = FALSE;
switch (get_underlying_type (fsig->params [1])) {
case MONO_TYPE_U1: op = is_c ? INTRINS_AARCH64_CRC32CB : INTRINS_AARCH64_CRC32B; break;
case MONO_TYPE_U2: op = is_c ? INTRINS_AARCH64_CRC32CH : INTRINS_AARCH64_CRC32H; break;
#if TARGET_SIZEOF_VOID_P == 4
case MONO_TYPE_I:
case MONO_TYPE_U:
#endif
case MONO_TYPE_U4: op = is_c ? INTRINS_AARCH64_CRC32CW : INTRINS_AARCH64_CRC32W; break;
case MONO_TYPE_U8: op = is_c ? INTRINS_AARCH64_CRC32CX : INTRINS_AARCH64_CRC32X; break;
#if TARGET_SIZEOF_VOID_P == 8
case MONO_TYPE_I:
case MONO_TYPE_U:
is_8byte_data = TRUE;
op = is_c ? INTRINS_AARCH64_CRC32CX : INTRINS_AARCH64_CRC32X;
break;
#endif
case MONO_TYPE_U8: is_8byte_data = TRUE; op = is_c ? INTRINS_AARCH64_CRC32CX : INTRINS_AARCH64_CRC32X; break;
default: g_assert_not_reached (); break;
}
return emit_simd_ins_for_sig (cfg, klass, is_64bit ? OP_XOP_I4_I4_I8 : OP_XOP_I4_I4_I4, op, arg0_type, fsig, args);
return emit_simd_ins_for_sig (cfg, klass, is_8byte_data ? OP_XOP_I4_I4_I8 : OP_XOP_I4_I4_I4, op, arg0_type, fsig, args);
}
default:
g_assert_not_reached (); // if a new API is added we need to either implement it or change IsSupported to false
Expand Down
Loading