Enable EventSource in System.Threading.Tasks.Tests#127744
Enable EventSource in System.Threading.Tasks.Tests#127744MichalStrehovsky merged 2 commits intomainfrom
Conversation
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @dotnet/area-system-threading-tasks |
There was a problem hiding this comment.
Pull request overview
This PR enables EventSource/EventPipe support when System.Threading.Tasks.Tests is built and run under NativeAOT, addressing failures in AsyncProfilerTests that expect runtime async EventSource events to be emitted.
Changes:
- Set
EventSourceSupporttotrueconditionally when$(TestNativeAot) == trueforSystem.Threading.Tasks.Tests.
🤖 Copilot Code Review — PR #127744Note This review was generated by GitHub Copilot. Holistic AssessmentMotivation: The test project uses Approach: Adding Summary: ✅ LGTM. Single-line csproj change follows an established convention. The condition is correctly scoped to NativeAOT only, avoiding any impact on CoreCLR/Mono test runs. No concerns. Detailed Findings✅ Correctness — Pattern matches established conventionThe ✅ Necessity — Tests genuinely require EventSourceThe test project includes files that directly use
These APIs are trimmed away without ✅ Scope — No collateral impactThe condition
|
|
A subset of tests need GetMethodFromNativeIP to work and I suspect that doesn't work for NativeAOT. I have another test PR coming up where I could exclude this and run the outerloop tests as well to make sure they pass on NativeAOT. We could temporarily disable the tests on NativeAOT in this PR and I can fix it in another PR I'm about to submit (enabling single threaded WASM as well). Could that be an option? |
|
@copilot, can you temporary disable the async profiler tests on native aot in this PR? |
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/c72d785e-5eef-4214-b199-32b053971928 Co-authored-by: lateralusX <11529140+lateralusX@users.noreply.github.com>
Done in commit 577cdd2. Added |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g failures are what I'm trying to fix elsewhere |
Might fix native AOT outerloops: