Skip to content

Re-enable OSX runtime-diagnostics legs #127492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcj1 merged 6 commits into from
May 1, 2026
+10 −5
Merged

Re-enable OSX runtime-diagnostics legs #127492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65036de
Update runtime-diagnostics.yml
rcj1 Apr 28, 2026
9acc3eb
Disable system dump generation
hoyosjs Apr 28, 2026
429026c
Check available space on entry
hoyosjs Apr 28, 2026
1dd0fbd
Apply suggestion from @Copilot
rcj1 Apr 28, 2026
bd0a3bf
Add same skip to the regular tests
hoyosjs Apr 29, 2026
730d030
Merge branch 'main' into reenable-osx
rcj1 May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions eng/pipelines/runtime-diagnostics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,8 @@ parameters:
- windows_arm64
- linux_arm64
- linux_arm
# TODO: Re-enable osx once disk space issue is resolved.
# macOS full dumps are ~5.7GB each; with 8+ full-dump debuggees the Helix
# machines run out of disk space (~45GB total). See PR #124782 for details.
# - osx_arm64
# - osx_x64
- osx_arm64
- osx_x64
Comment thread
rcj1 marked this conversation as resolved.
- name: cdacDumpTestMode
displayName: cDAC Dump Test Mode
type: string
Expand Down
4 changes: 4 additions & 0 deletions src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@
<HelixPreCommand Include="set DOTNET_DbgEnableMiniDump=1" />
</ItemGroup>
<ItemGroup Condition="'$(TargetOS)' != 'windows'">
<!-- Check available disk space before running tests -->
<HelixPreCommand Include="df -h" />
<!-- Disable core dumps (ulimit -c 0) since system cores are too large and we create many intentional crashes for tests, which would fill the machine. -->
<HelixPreCommand Include="ulimit -c 0" />
<HelixPreCommand Include="export DOTNET_DbgEnableMiniDump=1" />
<HelixPreCommand Include="chmod +x $HELIX_CORRELATION_PAYLOAD/dotnet" />
</ItemGroup>
Expand Down
4 changes: 4 additions & 0 deletions src/native/managed/cdac/tests/DumpTests/cdac-dump-xplat-test-helix.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@

<!-- Pre-commands -->
<ItemGroup Condition="'$(TargetOS)' != 'windows'">
<!-- Check available disk space before running tests -->
<HelixPreCommand Include="df -h" />
<!-- Disable core dumps (ulimit -c 0) since system cores are too large and we create many intentional crashes for tests, which would fill the machine. -->
<HelixPreCommand Include="ulimit -c 0" />
<HelixPreCommand Include="chmod +x $HELIX_CORRELATION_PAYLOAD/dotnet" />
</ItemGroup>

Expand Down
Loading