[RyuJit] Decouple igNum from strict layout order#125554
Merged
kg merged 8 commits intodotnet:mainfrom May 5, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Mar 14, 2026
5c0cfed to
5a29170
Compare
7c1f46a to
0d0b47e
Compare
0d0b47e to
2f5d8c9
Compare
2f5d8c9 to
66fe4a6
Compare
2 tasks
Member
|
/azp list |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This reverts commit 83336f9.
This was referenced Mar 28, 2026
Contributor
Author
|
@dotnet/jit-contrib |
Under stress + OSR + large phantom funclet frame, we may need to emit a jump that depends on the single IG.
Member
|
@AndyAyersMS , @kg , @adamperlin, PTAL. |
Member
|
We lost diffs so will merge up to get new ones. |
kg
reviewed
Apr 29, 2026
kg
approved these changes
Apr 30, 2026
Member
kg
left a comment
There was a problem hiding this comment.
LGTM but a second pair of eyes would be nice
Member
|
@dotnet/jit-contrib |
AndyAyersMS
approved these changes
May 5, 2026
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ultimate goal here is to remove the single-IG prolog constraint.
Currently, the
igNumorder matches the linked list order precisely (and thus the final layout order) precisely. It means we cannot generate any IGs "out of order". This change removes this restriction for a subset of IGs, those representing epilogs and funclet prologs, by hidingigNumbehind and abstraction of "before [in layout order] / after [in layout order]" APIs. These APIs rely in the linked list to ascertain ordering between out-of-order groups.Currently this is only exercised under a stress mode which splits all IGs into single-instruction groups. To this end, validation has been performed with this stress mode uncoditionally turned on for all methods [and all eligible IGs]:
Without stress, this is a zero-diff change since all our epilogs and funclet prologs fit into a single IG currently.