-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add support for floating-point hex formatting and parsing #124139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
756433a
Add support for floating-point hex formatting and parsing
stephentoub 6d4ba39
Address PR review feedback for hex float formatting/parsing
stephentoub 9112f47
Add additional hex float edge case tests
danmoseley aec06cb
Clean up hex float formatting: remove orphaned string, add assertions…
danmoseley 72cc040
Remove unreachable shiftRight == 0 branch in hex float parsing
danmoseley 102abdb
Add Debug.Assert for bitsToDiscard range in hex float formatter
danmoseley 51fa1ab
Clarify significand accumulation guards in hex float parser
danmoseley 3bda837
Assert shiftRight range after rounding logic in hex float parser
danmoseley f10634f
Emit 0x prefix
stephentoub f8a770d
Require 0x prefix when parsing
stephentoub 7acd9b9
Fix doc comment
stephentoub 5f44a7a
Require binary exponent (p/P) when parsing hex floats
stephentoub b4f8455
Apply suggestions from code review
stephentoub 9dfd36d
Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System…
stephentoub 1a4520f
Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System…
stephentoub 26ca896
Address PR review feedback for hex float formatting/parsing
stephentoub 199548f
Address tannergooding review feedback
stephentoub c032026
Add AllowExponent to HexFloat and fix exponent doc wording
stephentoub e7fa025
Guard against empty NegativeSign in hex float parsing
stephentoub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.